Open glatterf42 opened 5 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.5%. Comparing base (
afd7420
) to head (0d65d2d
). Report is 1 commits behind head on main.
Hi Fridolin,
Nice to hear from you.
I'm sending attached some suggestions of images. Please feel free to use the most suitable one.
Here is the link for the paper: https://www.sciencedirect.com/science/article/pii/S2352152X2400834X#f0010
Let me know if you need any extra info.
Best, Natalia
[image: SPHS.jpg][image: BESSM model overview.jpg][image: BESSM model.jpg][image: Methodology.jpg]
On Wed, Nov 13, 2024 at 2:38 PM Fridolin Glatter @.***> wrote:
Thanks to @shreeyashn20 https://github.com/shreeyashn20 in #883 https://github.com/iiasa/message_ix/discussions/883, I have been made aware of the paper https://www.sciencedirect.com/science/article/pii/S2352152X2400834X by @natiweber https://github.com/natiweber about the Brazilian energy model with seasonal pumped hydropower storage. This PR adds a link to that to the docs. It also links our new community health files from our contributing page.
@natiweber https://github.com/natiweber or @behnam-zakeri https://github.com/behnam-zakeri (since you are a co-author): we usually use a preview image for the entries on our usage page. Please let me know if you have an image in mind that we can use for that :) How to review
- Read the diff and note that the CI checks all pass.
- Look at the pages in the docs that changed and confirm they look good:
- TBD
PR checklist
- Continuous integration checks all ✅
- [ ] Add or expand tests; coverage checks both ✅ Just updating docs.
- Add, expand, or update documentation.
- [ ] Update release notes. Just updating docs.
You can view, comment on, or merge this pull request online at:
https://github.com/iiasa/message_ix/pull/888 Commit Summary
- 827accf https://github.com/iiasa/message_ix/pull/888/commits/827accfc27b3e992c54a34c89395a1a0b2285a8a Add new paper to bibliography
- c50d010 https://github.com/iiasa/message_ix/pull/888/commits/c50d0109c371aeec4333b10172577ec8d4c5397f Add paragraph about new paper to docs
- fac4740 https://github.com/iiasa/message_ix/pull/888/commits/fac47406fce18969a45c4410f1ddd584f8275f80 Add links to community health files to contributing page
File Changes
(3 files https://github.com/iiasa/message_ix/pull/888/files)
- M doc/contributing.rst https://github.com/iiasa/message_ix/pull/888/files#diff-13795c17121ec235cc0d7a1f5df177f3a5af2e32d2cbd2d95c8b020ad8c76516 (5)
- M doc/references.bib https://github.com/iiasa/message_ix/pull/888/files#diff-377b988b90a7f40ae57540205224bac7050f568f9a76c518e20e76e899134655 (14)
- M doc/usage.rst https://github.com/iiasa/message_ix/pull/888/files#diff-e2f32bf1fe37315337b25b0d5efe2a8dde59b0f5ea2c3d6fddcf3f8b6d0fe9d1 (15)
Patch Links:
- https://github.com/iiasa/message_ix/pull/888.patch
- https://github.com/iiasa/message_ix/pull/888.diff
— Reply to this email directly, view it on GitHub https://github.com/iiasa/message_ix/pull/888, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANUUQ37UKOLR2FMRX4UYLQT2ANI5FAVCNFSM6AAAAABRWQNS2WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TKNJVGY3DINQ . You are receiving this because you were mentioned.Message ID: @.***>
-- Natalia Weber, Dr. Ing. Mentoring Programme Coordinator 📞 +43 676 551 3831 🌐 LinkedIn http://www.linkedin.com/in/natalia-ab-weber
Thanks for the suggestions, let's see how we like the one I used now :)
Thanks to @shreeyashn20 in #883, I have been made aware of the paper by @natiweber about the Brazilian energy model with seasonal pumped hydropower storage. This PR adds a link to that to the docs. It also links our new community health files from our contributing page.
@natiweber or @behnam-zakeri (since you are a co-author): we usually use a preview image for the entries on our usage page. Please let me know if you have an image in mind that we can use for that :)
How to review
PR checklist