Closed phackstock closed 3 months ago
Since the source data file is coming from the EU I'd say it's safe to assume there aren't any mistakes in there. Therefore, technically this code:
https://github.com/iiasa/pysquirrel/blob/5d8005389d78f42a65863c3b175f879684d58643/src/pysquirrel/core.py#L37-L89
is not required.
I'm not quite sure if we should keep it or remove it.
Reasons to keep:
Reasons to remove:
What do you think @dc-almeida and @danielhuppmann?
If there's no harm and if it's nicely implemented, I'd say let's keep it. Maybe people can use it when developing similar packages for other world regions.
Closing for now as we're keeping the validators.
Since the source data file is coming from the EU I'd say it's safe to assume there aren't any mistakes in there. Therefore, technically this code:
https://github.com/iiasa/pysquirrel/blob/5d8005389d78f42a65863c3b175f879684d58643/src/pysquirrel/core.py#L37-L89
is not required.
I'm not quite sure if we should keep it or remove it.
Reasons to keep:
Reasons to remove:
What do you think @dc-almeida and @danielhuppmann?