Closed phackstock closed 3 months ago
I would change the variable name unit in here:
unit
https://github.com/iiasa/pysquirrel/blob/5d8005389d78f42a65863c3b175f879684d58643/src/pysquirrel/core.py#L123-L144
to region. Especially in the context of IAMC data we use unit to mean a physical unit. Since you are reading in regions, I think using region would be more logical and easier to read.
region
I would change the variable name
unitin here:https://github.com/iiasa/pysquirrel/blob/5d8005389d78f42a65863c3b175f879684d58643/src/pysquirrel/core.py#L123-L144
to
region. Especially in the context of IAMC data we use unit to mean a physical unit. Since you are reading in regions, I think usingregionwould be more logical and easier to read.