search

iib0011 / omni-tools

Collection of handy online tools for everyone, with great UX.
https://omnitools.netlify.app/
MIT License
14 stars 1 forks source link

Convert jpg to png #4

Closed iib0011 closed 2 months ago

iib0011 commented 2 months ago

Create a page like https://onlinepngtools.com/convert-jpg-to-png

omertairi04 commented 2 months ago

Where should i put the backend, which is mostly what i will work in?

iib0011 commented 2 months ago

No we'll do everything in the front

omertairi04 commented 2 months ago

Oh... the issue is that i have no experience in front end. I will try to do some stuff using online documentation i can find but still cant promise good results.

iib0011 commented 2 months ago

Ok. Take your time

iib0011 commented 2 months ago

@hhourani27 Will you work on this issue?

hhourani27 commented 2 months ago

@iib0011, sorry for the late reply. I'm on it!

hhourani27 commented 2 months ago

Just finished committing on the branch. I did not do the "PNG Transparency Mask" feature. Do you think it's useful? If you don't think so, I'll shoot the PR right away

iib0011 commented 2 months ago

@hhourani27 Not worth it. Thanks. I didn't find other tools using it

hhourani27 commented 2 months ago

Ok great! I'll try adding some e2e tests (the image tools are lacking tests), and maybe externalize some color functions (eg. similarity calculations), and then I'll create the PR