search

iidb / wing

Educational DB for Database System course at IIIS (Yao class), Tsinghua University
MIT License
4 stars 0 forks source link

Question about bloom_filter test in SSTableTest #4

Open AcKing-Sam opened 1 month ago

AcKing-Sam commented 1 month ago

Hi, I have a question about the bloom_filter test in SSTableTest.

The test inserted 1e5 keys and tested 5e6 uninserted keys, but it failed on my local machine. Is it related to the computing power of my local CPU? For example, I changed it to insert 5e4 keys and 2e5 uninserted keys, and it passed.

Thanks!

yfzcsc commented 4 days ago

Hello, sorry for my late response, the time limits of tests are determined by measuring the execution time on our course server, so it defintely related to your hardware configuration. If you just want to check the correctness, and you ensure that there are no errors on the time complexity, you can change the time limit. I am very happy to see someone else to do this project. Also, if you have any idea to improve the testing method, or the documents, please feel free to make comments.

AcKing-Sam commented 1 day ago

@yfzcsc Thank you for the response! This project is awesome and I appreciate it for all your efforts!