iiegor / xat-server

A Node.js private server of xat.com
6 stars 2 forks source link

Triage important tasks #7

Open iiegor opened 8 years ago

iiegor commented 8 years ago

:arrow_up: xat-server@0.1.0


huumanoid commented 8 years ago

Let's discuss. What is left to do with Correct user authentication?

NOTE:

class Test
  u: { m: 0 }

it's unsafe way to initialize bar. in this way, all instances of Test works with same copy of u

a = new Test
a.u.m++
b = new Test
console.log(b.u,m)

guess what? ;) this note related to iiegor/xat-server@9a476e6ac8ce741a644b5562e2ccb1a87170c173 It seems that it's not tempfix, it is the safe way to initialize 'user' field.

iiegor commented 8 years ago

@HuuMaNoID It seems that only remains to fix the authentication for guest users and probably complete some missing user packets, regarding that task.

wow, you are completely right about the initialization of the variables :fearful:

Non-related: I added you as a collaborator so this way we can make more easier the development. Only push directly to the repo very important and small changes, for the others create pull requests to discuss the changes.

huumanoid commented 8 years ago

Verify user identity when sending commands This task requires user rank implementation, isn't it?

Select only needed data How do you see it? Maybe we may pass required fields to getById function?

iiegor commented 8 years ago

@HuuMaNoID Yes, the user identity verification requires of the user rank. Regarding the second question, I think your idea it's perfect ;)