Error get_provider_name

iignatov / LightOpenID

Lightweight PHP5 library for easy OpenID authentication.

MIT License

77 stars 95 forks source link

Error get_provider_name #12

Closed bryanrmq closed 8 years ago

bryanrmq commented 8 years ago

Hi,

I found a mistake inside the class. (v1.3.0 (2016-02-20)) line 690 : get_provider_name($this->claimed_id) == 'yahoo'

PHP said : Fatal error: Call to undefined function get_provider_name() '$this' is missing. I added it and it's working perfectly now.

bryanrmq commented 8 years ago

Oups I just saw the pull request with the same subject...

Arthom commented 8 years ago

i merged the bugfix :)

you need to change get_provider_name to $this->get_provider_name

iignatov commented 8 years ago

@Arthom, thanks for the PR!

iignatov commented 8 years ago

Thanks for the notice, guys!

I don't use this library (or PHP at all) anymore, so I didn't have an environment to test the whole library after the change and only tested the function implementation itself in an online PHP-sandbox.

I merged the PR, the issue is now fixed.