iigorr / pgn.net

Portable Game Notation (PGN) implementation in .NET
Other
33 stars 24 forks source link

Any interest in PGN.NET Core? #20

Open teodoran opened 5 years ago

teodoran commented 5 years ago

I needed a .NET Core library for working with PGN, but couldn't find any, and ended up porting PGN.NET to .NET Core. The plan was originally to do a quick and dirty port, and just use it for my own hobby project, but after a while I started having fun porting, and suddenly I ended up with something that someone else could use as well. It's all up on teodoran/pgn.net.

I was thinking about submitting a PR back to you, but since I started out only thinking about my own needs, I've changed stuff quite a bit, so the diff back to PGN.NET is quite bad :sweat_smile:

Now I'm wondering what I should do with it. Would you like me to:

  1. Submit a PR so you can consider including it into PGN.NET?
  2. Set up PGN.NET Core as a separate library, and support it on my own?
  3. Just use it for my own needs and let you do a port of PGN.NET if and when you want to do it?
  4. Something else?

Anyways, cheers for a nice library! :beers: I've been wanting to take a look at FParsec for a long time, and working with PGN.NET finally gave me the opportunity to take a closer look.

Qara-Penimah commented 5 years ago

Option 3 would be a tragedy IMO. Option 1 will deny those who haven't yet transitioned to .NET Core and probably won't for a very long time -- cross-platform doesn't matter much to a lot of in-house teams. Option 2 sounds like a good idea to me. It possibly suits my selfish needs as this seems like a project I can make contributions.

crick3t commented 1 year ago

I have a feeling neither option 1 or option 2 happened in the last 4 years as it is not working for me in .NET core. But Let me know if it should and I just missed something. Is the other one maintained? Should I start to use that one (and contribute there if needed)?

crick3t commented 1 year ago

I guess this answers my question. Or maybe not as it is not @teodoran 's comment... https://github.com/iigorr/pgn.net/issues/22 I put it here for the others who end up here. :)