search

iiiMatt / WiSe-2023-24

0 stars 1 forks source link

Definitions for `extract_salutations` and `infer_age` #2

Closed iiiMatt closed 9 months ago

iiiMatt commented 9 months ago

Update to the preprocessing pipeline and definitions for extract_salutations and infer_age.

smnehong commented 9 months ago

I think it's good. We could think about passing only the attributes of the dataset to the functions so that the dataset doesn't have to be copied every time we call a function. Function calls in generate_preprocessed_data would then look like dataset[["Salutation"]] <- extract_salutations(dataset[["Name"]]).

iiiMatt commented 9 months ago

I think it's good. We could think about passing only the attributes of the dataset to the functions so that the dataset doesn't have to be copied every time we call a function. Function calls in generate_preprocessed_data would then look like dataset[["Salutation"]] <- extract_salutations(dataset[["Name"]]).

In this case it would be unnecessary, because the dataset is so small, but good remark!