search

iiif-prezi / iiif-prezi3

IIIF Presentation API 3 Python Library
https://iiif-prezi.github.io/iiif-prezi3/
Apache License 2.0
28 stars 14 forks source link

Adds add_thumbnail helper #145

Closed helrond closed 1 year ago

helrond commented 1 year ago

Any idea why the docs build is blowing up? I can run that same command locally without errors.

digitaldogsbody commented 1 year ago

It says a cyclic reference detected. It builds in strict mode for PRs, so it might be that it will be ok when merged. I'll pull locally and see if I can get any more useful diagostics.

digitaldogsbody commented 1 year ago

Strict mode also worked fine for me locally :confused:

digitaldogsbody commented 1 year ago

Seems to be an issue with the use of uuid somewhere?

griffe.exceptions.CyclicAliasError: Cyclic aliases detected: uuid

digitaldogsbody commented 1 year ago

Looks like the latest version of Griffe (released yesterday) has a change to how alias resolution works: https://github.com/mkdocstrings/griffe/blob/master/CHANGELOG.md.

I will pin the requirements to the previous version as a temporary fix.

digitaldogsbody commented 1 year ago

I've opened an issue in the griffe repo: https://github.com/mkdocstrings/griffe/issues/123