search

iiitl / GitHub-Finder

0 stars 12 forks source link

Tags section fix #8

Open akshat-bhansali opened 8 months ago

akshat-bhansali commented 8 months ago

The tags section present in the current user's page needs its UI to be fixed. The "SAVE" button only enables when there is some change in the tags.Color changes from red to blue when button is enabled. Changes to be made :-

  1. "SAVE" and "TAGS" button height shouldn't increase or decrease when tags are added or removed respectively.
  2. The tags which are already present in the list shouldn't be present in the dropdown.
  3. Add padding to selected tags. Screenshot 2024-03-14 at 11 22 20 PM
0PrashantYadav0 commented 8 months ago

@akshat-bhansali i would like to work on this so please aassign this to me

akshat-bhansali commented 8 months ago

@0PrashantYadav0 please explain me your approach first

0PrashantYadav0 commented 8 months ago

@akshat-bhansali

  1. For button and tag height, we just have to put it inside another div so that it will not grow in size after adding.
  2. As there are only 2 element in tag list so it will be easy to render the dropdown on condition that they are present at userTags[0] || userTags[1]
  3. Padding will adjust using tailwind.

This will be my approach

Screenshot 2024-03-15 at 3 43 10 PM
akshat-bhansali commented 8 months ago

Sounds good,before using userTags [1] just check if there are 2 tags assigned at that point or else it will give run time error I am assigning you the issue 👍🏻

0PrashantYadav0 commented 8 months ago

@akshat-bhansali i have create a PR in which i have fixed all the bugs and make changes as per the need.