iiitl / bash-practice-repo-24

0 stars 35 forks source link

added feature: Music extractor #112

Closed Sidharth-Singh10 closed 5 months ago

Sidharth-Singh10 commented 5 months ago

This script is designed to convert all .mp4 files in the current directory and its subdirectories into .mp3 files and store them in the Music directory. Here's a breakdown of the implementation:

Overall, the script finds all .mp4 files, creates the corresponding directories in the Music directory, and then converts each .mp4 file to .mp3, storing them in the Music directory.

rootCircle commented 5 months ago

hi @Sidharth-Singh10, please avoid putting full code explanation in PR description! PR description is a general overview of what your changes will do/fix, and high level description of how you fixed it, any system metadata etc.

rootCircle commented 5 months ago

@Sidharth-Singh10 There is a bug in your implementation, can you check it once?

image

rootCircle commented 5 months ago

fixes #91

Sidharth-Singh10 commented 5 months ago

@rootCircle I tried to solve the bug to best of my knowledge. I failed to do so. I am closing this PR as I cannot move further.