iiitl / bash-practice-repo-24

0 stars 35 forks source link

Made a ffmpeg script which takes all the mp4 files in a folder . #113

Closed shuklamaneesh23 closed 5 months ago

shuklamaneesh23 commented 5 months ago

@rootCircle ,solved the issue #91 ,

This PR enhances the audio extraction script to incorporate user interaction for specifying input and output folders. Here's a breakdown of the implementation:

Implementation Logic:

  1. User Input Prompting:

    • Utilizes the read command to prompt users for the paths of the input and output folders.
    • Prompts users to enter the path of the folder containing MP4 files and the path to save the extracted audio files.
  2. Audio Extraction Function:

    • The extract_audio function remains unchanged and handles the audio extraction process.
    • Checks if the input folder exists and creates the output folder if it doesn't exist.
    • Recursively searches for MP4 files in the input folder using find.
    • Utilizes ffmpeg to extract audio from each MP4 file and saves it as an MP3 file in the output folder.
    • Provides informative messages indicating successful extractions or failures.
  3. Improved User Experience:

    • By allowing users to input folder paths, the script offers greater flexibility and usability.
    • Users receive clear feedback throughout the extraction process, ensuring a smooth and informative experience.

This PR enhances the script's functionality and user-friendliness by enabling users to specify input and output folders interactively, enhancing overall usability.

Screenshot of the same:

Screenshot 2024-03-17 at 11 32 16 AM
rootCircle commented 5 months ago

Your implementation simply fails to run, have you tested it? (Check your own screenshot as well)

image

Closing this as invalid, if you have found correct implementation, please make a new PR