iiitl / bash-practice-repo-24

0 stars 35 forks source link

Implement Password Generation Functions #142

Closed Karanagarwal12 closed 5 months ago

Karanagarwal12 commented 5 months ago

Fixes issue #5 -Created a function to generate passwords with specified length

Changes Made:

Additional Notes:

image

ecxtacy commented 5 months ago

Nice try, although you could use an inbuilt library for this too. Good work

rootCircle commented 5 months ago

well, it's really impressive that implemented from scratch, so i will assign extra points just for efforts!

Although as @ecxtacy mentioned too, there ass standard default lib, that can help you with that, actual problem with your implementation will be that random is not crypto-graphically secure here! But we are not solving Y problem here!

rootCircle commented 5 months ago

LGTM :+1: Accepted