iiitl / bash-practice-repo-24

0 stars 35 forks source link

added code for cpu temperature #72

Closed AMANVISHWAKARMA27 closed 6 months ago

AMANVISHWAKARMA27 commented 6 months ago

fixes #8

image

rootCircle commented 6 months ago

your pr still doesn't solves the issues as stated in #8. The values are presumably in mill-celcius and mill-farhenheit.

image

please fix that! also write good pr description and include screenshot of your code running/ not your code (we can see the changes in the File changes tab above)

ping me here when you're done with those/need any help, so we can move forward with your PR!

AMANVISHWAKARMA27 commented 6 months ago

@rootCircle please review the code again. Also I encountered a problem that the code was not problem properly on my system as I am on windows and use Ubuntu subsystem ,so I ran it on my friends system which is Linux. There it ran correctly. WhatsApp Image 2024-03-17 at 10 17 43_cceb653c

rootCircle commented 6 months ago

Also I encountered a problem that the code was not problem properly so I ran it on my friends system which is Linux. There it ran correctly.

Hey! @AMANVISHWAKARMA27, actually currently your implementation truncates the decimal place values, can you come up with something that includes that too in your code

So, Temperature in Celsius: 48.2 C Instead of Temperature in Celsius: 48 C

AMANVISHWAKARMA27 commented 6 months ago

Also I encountered a problem that the code was not problem properly so I ran it on my friends system which is Linux. There it ran correctly.

Hey! @AMANVISHWAKARMA27, actually currently your implementation truncates the decimal place values, can you come up with something that includes that too in your code

So, Temperature in Celsius: 48.2 C Instead of Temperature in Celsius: 48 C

Yess I can try.

rootCircle commented 6 months ago

ping me here when you're done with those/need any help, so we can move forward with your PR!

AMANVISHWAKARMA27 commented 6 months ago

@rootCircle , it is fine now. Giving output upto two decimal places. WhatsApp Image 2024-03-17 at 10 29 49_921bbf19

rootCircle commented 6 months ago

LGTM :+1: Accepted Thanks for your contribution!