iiitl / bash-practice-repo-24

0 stars 35 forks source link

prints permission in octal format #6 #82

Closed AMANVISHWAKARMA27 closed 6 months ago

AMANVISHWAKARMA27 commented 6 months ago

Fixes #6 image

rootCircle commented 6 months ago

hi @AMANVISHWAKARMA27, thanks for contribution!

few things, please include function usage in the code itself, include screenshot in PR description as well!

rootCircle commented 6 months ago

ping me here when you're done with those/need any help, so we can move forward with your PR!

AMANVISHWAKARMA27 commented 6 months ago

hi @AMANVISHWAKARMA27, thanks for contribution!

few things, please include function usage in the code itself, include screenshot in PR description as well!

@rootCircle, if u could explain me in a bit more detail what I have to do ?

rootCircle commented 6 months ago

@rootCircle, if u could explain me in a bit more detail what I have to do ?

currently you have the function, but we are not using up to satisfy the issue description!

simply put, issue description requires something like this given below, but your code does doesn't provide the usage

> perms README.md
642 README.md
AMANVISHWAKARMA27 commented 6 months ago

@rootCircle, if u could explain me in a bit more detail what I have to do ?

currently you have the function, but we are not using up to satisfy the issue description!

simply put, issue description requires something like this given below, but your code does doesn't provide the usage

> perms README.md
642 README.md

Ahh got it. Doing it asap.

AMANVISHWAKARMA27 commented 6 months ago

@rootCircle , it is done now as per your suggestion. Screenshot 2024-03-17 105932

rootCircle commented 6 months ago

LGTM :+1: Accepted!