Closed marizvi closed 2 years ago
M-A-D-A-R-A
commented
2 years ago This PR is with reference to Issue #18.
Hello, I have fixed this issue as mentioned above in the title. The Screenshot is attached below:
If everything looks fine then kindly merge this issue under contribute-a-thon'21. And if anything else is missing related to this issue then kindly let me know.
@AshishSingh2001 @kapilkumar2001 Please review the changes !
M-A-D-A-R-A
commented
2 years ago This PR is with reference to Issue #18. Hello, I have fixed this issue as mentioned above in the title. The Screenshot is attached below: If everything looks fine then kindly merge this issue under contribute-a-thon'21. And if anything else is missing related to this issue then kindly let me know.
@AshishSingh2001 @kapilkumar2001 Please review the changes !
what i can see is that @marizvi you changed the height dimensions , what we want is that u make it responsive so that it wont overflow on any size devices, so please try to make it more Responsive.
marizvi
commented
2 years ago Yeah Sure, I will do it
marizvi
commented
2 years ago Hello, Sorry for the delay sir. I have successfully added the responsiveness as well to the above-mentioned issue, I have attached screenshots related to the same, Kindly now have a look at it,
If everything looks fine then kindly merge my part of the code as well, under contribute-a-thon'21.
AshishSingh2001
commented
2 years ago Hello, Sorry for the delay sir. I have successfully added the responsiveness as well to the above-mentioned issue, I have attached screenshots related to the same, Kindly now have a look at it,
If everything looks fine then kindly merge my part of the code as well, under contribute-a-thon'21.
Remove the auto rotation ( landscape mode) from the app , also make sure there is only one image shown at a time.
marizvi
commented
2 years ago Hello Sir, I did exactly what you wanted, Kindly have a look at it and let me know if there are any more changes needed related to this issue.
If all is fine then kindly merge it under contribute-a-thon'21.
This PR is with reference to Issue #18.
Hello, I have fixed this issue as mentioned above in the title. The Screenshot is attached below:
If everything looks fine then kindly merge this issue under contribute-a-thon'21. And if anything else is missing related to this issue then kindly let me know.