search

iiitv / algos

Popular Algorithms and Data Structures implemented in popular languages
MIT License
1.07k stars 496 forks source link

Red Black Tree [Python] #228

Open stanislavkozlovski opened 7 years ago

stanislavkozlovski commented 7 years ago

Implement the classic Red Black Tree (not the left-leaning one) https://en.wikipedia.org/wiki/Red%E2%80%93black_tree

Monal5031 commented 7 years ago

@Enether if you wish to send a PR for this issue please get it assigned :smile: its great to see new contributors.

stanislavkozlovski commented 7 years ago

@Monal5031 I have a big file with tests for said tree, but that file does not adhere to PEP8, mainly having really long lines, which are really comments that draw out the tree. Should I add the tests file at all?

singhpratyush commented 7 years ago

@Enether: Add those files and we can decide what to do with it.

Monal5031 commented 7 years ago

@Enether You can use coala locally to fix the PEP8 issues really fast.

stanislavkozlovski commented 7 years ago

@Monal5031 sure but those comments are not fixable as they draw out a tree and spreading them into multiple lines would confuse the reader/

Monal5031 commented 7 years ago

@Enether Okay, upload it we'll see what to do.

singhpratyush commented 7 years ago

@Enether: Are you working on it?

stanislavkozlovski commented 7 years ago

Yes, should have it done by the end of this weekend

Monal5031 commented 7 years ago

@Enether any updates for this issue?