search

iiitv / getmein-web

Portal to get an invite to IIITV GitHub organization
https://getmein.glitch.me/
MIT License
28 stars 44 forks source link

Add a code linter #13

Open aashutoshrathi opened 5 years ago

aashutoshrathi commented 5 years ago

Add coala or similar linter for JS files. Anyone from @iiitv/batch-of-2021, please take this issue.

rahulrana95 commented 5 years ago

@aashutoshrathi can you assign me this issue or I can open a PR?

aashutoshrathi commented 5 years ago

@rahulrana95 Join our organization using http://getmein.glitch.me Thanks

rahulrana95 commented 5 years ago

@aashutoshrathi I have joined the organization. Can you assign the issue to me?

aashutoshrathi commented 5 years ago

Assigned @rahulrana95

rahulrana95 commented 5 years ago

@aashutoshrathi I am not able to push to a new feature branch. Please give me permissions.

aashutoshrathi commented 5 years ago

Fork and send a PR @rahulrana95

neolivz commented 5 years ago

Just curious why coala than eslint?

aashutoshrathi commented 5 years ago

We have had good relations with @coala and also have few of our members as active contributors there, plus its easy to integrate, I think.

rahulrana95 commented 5 years ago

@aashutoshrathi I have tried coala linter for js but I am not able to find proper documentation to setup it properly. Eslint is widely used as linter for js codebases

aashutoshrathi commented 5 years ago

A sample commit for you: https://github.com/iiitv/algos/commit/297da0f966d3f1a8bbb4e3e4f5e2d7b7c22dfb9a#diff-e7d7d93b4c8d0df9c9bf21a7d47c83b5 Feel free to read it. 😄

rahulrana95 commented 5 years ago

@aashutoshrathi then we can merge the coala one PR i have make. Its working. I just need to add more bears to it else its working as of now.