iiitv / getmein-web

Portal to get an invite to IIITV GitHub organization
https://getmein.glitch.me/
MIT License
28 stars 44 forks source link

added button to contribution guidelines and COC #130

Closed nlok5923 closed 3 years ago

nlok5923 commented 3 years ago

Description

Added button for contribution guidelines and code of conduct.

Screenshot Before Change:

Screenshot (1387)

Screenshot After Change:

Screenshot (1386)

Types of changes

Non Functional Requirement

deployment link : https://nlok5923-getmein-web-7.glitch.me/

nlok5923 commented 3 years ago

@iiitv/project-maintainers please review this pull request.

nlok5923 commented 3 years ago

After changes : test link : https://nlok5923-getmein-web-8.glitch.me/

Screenshot (1389)

nlok5923 commented 3 years ago

@aashutoshrathi Sir, there isn't much space for buttons while maintaining the same space as it is between the submit button and span element. that's why i has to apply uk-margin-remove to the footer div . but sir if we has to keep footer in the same way as before we has to go with this implementation while keeping the page fits in 100vh .

Screenshot (1401)

or if we can make page scrollable we can go with buttons. sir if there any other possible option please let me know.