iiitv / getmein-web

Portal to get an invite to IIITV GitHub organization
https://getmeiniiitv.glitch.me/
MIT License
28 stars 44 forks source link

Add Instruction to take a look at Code of Conduct and Contribution Guidelines #54

Open aashutoshrathi opened 6 years ago

aashutoshrathi commented 6 years ago

Add Instruction to take a look at Code of Conduct and Contribution Guidelines on getmein web page, email sent to new member and README too.

Ananthavijay commented 6 years ago

screenshot 1

Is this Fine @aashutoshrathi

nlok5923 commented 4 years ago

@iiitv/project-maintainers if this issue is still open i would like to work on it.

anujpuri72 commented 4 years ago

@nlok5923 GFI

nlok5923 commented 4 years ago

@aashutoshrathi sir please can you help me . I am getting an error while committing changes. Screenshot (1346)

I tried resolving it via some google search but didn't get out of it.

aashutoshrathi commented 4 years ago

Try replacing ./node_modules/eslint/bin/eslint.js with eslint in your package.json, don't commit it for now.

nlok5923 commented 4 years ago

@aashutoshrathi thanks sir it worked out . but sir when to commit those changes then.

aashutoshrathi commented 4 years ago

@iiitv/project-maintainers We need to make separate issue to make changes in package.json, right?

nlok5923 commented 4 years ago

@aashutoshrathi sir if you want i can work on it.

nlok5923 commented 4 years ago

@aashutoshrathi sir I tried to implement the feature and keeping the height 100vh in this manner. Screenshot (1350) is it fine sir.

theyashshahs commented 4 years ago

@nlok5923 also check if your implementation is responsive or not

nlok5923 commented 4 years ago

@yashshah2820 sir i checked the above implementation breaks in some mobile sized view. so i changed it a bit. Screenshot (1352)

theyashshahs commented 4 years ago

please provide a testing link for this 🙂

nlok5923 commented 4 years ago

@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/

Welcome to IIITV
Portal to get an invite to IIITV Github organization
theyashshahs commented 4 years ago

@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/

Welcome to IIITVPortal to get an invite to IIITV Github organization

have you created a PR for these changes?

Welcome to IIITV
Portal to get an invite to IIITV Github organization
nlok5923 commented 4 years ago

@yashshah2820 no sir for commiting this changes first the issue #124 should get resolved as this issue not allowing me to commit anything.

nlok5923 commented 4 years ago

can we do this : @iiitv/project-maintainers sir is it possible that i make pr for resolving this issue by replacing ./node_modules/eslint/bin/eslint.js with eslint in package.json and later on we can resolve #124 .

aashutoshrathi commented 4 years ago

Hey, read more about git add (Surprise, its not only git add .) command and how you can skip committing and staging files. I think we can get this PR done without touching package.json.

nlok5923 commented 4 years ago

@aashutoshrathi ohh so sorry sir i really forgotten about the same thank you sir

Ayush-Khandelwal28 commented 2 years ago

@iiitv/project-maintainers, I would like to work on the issue.

AkhileshManda commented 2 years ago

@iiitv/react-maintainers @Im-Madhur-Gupta