Open aashutoshrathi opened 6 years ago
Is this Fine @aashutoshrathi
@iiitv/project-maintainers if this issue is still open i would like to work on it.
@nlok5923 GFI
@aashutoshrathi sir please can you help me . I am getting an error while committing changes.
I tried resolving it via some google search but didn't get out of it.
Try replacing ./node_modules/eslint/bin/eslint.js
with eslint
in your package.json, don't commit it for now.
@aashutoshrathi thanks sir it worked out . but sir when to commit those changes then.
@iiitv/project-maintainers We need to make separate issue to make changes in package.json, right?
@aashutoshrathi sir if you want i can work on it.
@aashutoshrathi sir I tried to implement the feature and keeping the height 100vh in this manner. is it fine sir.
@nlok5923 also check if your implementation is responsive or not
@yashshah2820 sir i checked the above implementation breaks in some mobile sized view. so i changed it a bit.
please provide a testing link for this 🙂
@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/
Portal to get an invite to IIITV Github organization
@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/
Welcome to IIITVPortal to get an invite to IIITV Github organization
have you created a PR for these changes?
Portal to get an invite to IIITV Github organization
@yashshah2820 no sir for commiting this changes first the issue #124 should get resolved as this issue not allowing me to commit anything.
can we do this :
@iiitv/project-maintainers sir is it possible that i make pr for resolving this issue by replacing ./node_modules/eslint/bin/eslint.js
with eslint
in package.json and later on we can resolve #124 .
Hey, read more about git add
(Surprise, its not only git add .
) command and how you can skip committing and staging files.
I think we can get this PR done without touching package.json
.
@aashutoshrathi ohh so sorry sir i really forgotten about the same thank you sir
@iiitv/project-maintainers, I would like to work on the issue.
@iiitv/react-maintainers @Im-Madhur-Gupta
Add Instruction to take a look at Code of Conduct and Contribution Guidelines on getmein web page, email sent to new member and README too.