search

iiitv / hackiiitv

IIITV Hackathon Portal 2018
https://hack.iiitv.ac.in
GNU Affero General Public License v3.0
13 stars 9 forks source link

About Us Added & Scroll bar fixed according to theme #5

Closed pAditya198 closed 4 years ago

pAditya198 commented 4 years ago

About Page added

Screenshot (163)

Screenshot (164)

pAditya198 commented 4 years ago

Okay I'll make it so.

aashutoshrathi commented 4 years ago

Also the UI is too plain even for a doc.

pAditya198 commented 4 years ago

I think about us and CoC should be accessible without login.

But initially when the user visits login page appears, so where am I going to place the about page.

pAditya198 commented 4 years ago

UI for the page is changed

Screenshot (165)

Screenshot (166)

pAditya198 commented 4 years ago

I've not yet made about us page accessible without login. I think it will be better to keep it this way , adding about us in login page will not look good.

pAditya198 commented 4 years ago

Screenshot (167)

Monal5031 commented 4 years ago

ping @aashutoshrathi

pAditya198 commented 4 years ago

Screenshot (168)

@anshumanv done with the mark and the page please review, @aashutoshrathi .

pAditya198 commented 4 years ago

Screenshot (169)

pAditya198 commented 4 years ago

@anshumanv please also suggest improvements that could've been done from my side😅?

anshumanv commented 4 years ago

It's great work overall. 👍

@anshumanv please also suggest improvements that could've been done from my side😅?

Never used angular but I feel(correct me if I'm wrong) we don't need controllers nor resolvers since it's a simple static page. Also we need about's state outside of app state since we need unauthenticated access. And some formatting changes here and there.