Closed yotsuya closed 6 years ago
Nice description. 👍 Easy to get your intention!
To-Be
getUsers
returns a list of acquaintances of the current domain. The head of the list should beme
.getTalkRooms
returns a list ofTalkRoom
of the current domain. TheirtalkUsers
should be a list of all members of the talk.
But I have one question: actually these new behaviors are implemented as separate functions: retrieveUsers
, retrieveTalkRooms
, right?
Nice description. 👍 Easy to get your intention!
Thanks! 😊
getUsers
returns a list of acquaintances of the current domain. The head of the list should beme
.getTalkRooms
returns a list ofTalkRoom
of the current domain. TheirtalkUsers
should be a list of all members of the talk.But I have one question: actually these new behaviors are implemented as separate functions:
retrieveUsers
,retrieveTalkRooms
, right?
Are you saying that the behavior of getUsers/TalkRooms
are still not changed?
You can confirm that these new behaviors by running direct4b get users/talks
. These commands are using getUsers/TalkRooms
.
retreiveUsers/TalkRooms
are helper functions to update users/talks of Client
when setCurrentDomain
called. So, I'm planning move these codes to other module.
Are you saying that the behavior of getUsers/TalkRooms are still not changed?
Sorry, I've misunderstood.
I added some fixes for feedback.
setCurrentDomain
.setCurrentDomain
from export list of Web.Direct
.direct4b get all
command.fromGetTalks
to make it readable.I'd appriciate it if you would review again. 🙏
This PR fixes the behavior of
Web.Direct.getUsers
andWeb.Direct.getTalkRooms
when the loggeed-in user belongs to multiple domains.As-Is
getUsers
returns just[me]
regardless of the actual users. (#48)getTalkRooms
returns a list ofTalkRoom
of all domains. However, all of theirtalkUsers
is just[me]
.To-Be
getUsers
returns a list of acquaintances of the current domain. The head of the list should beme
.getTalkRooms
returns a list ofTalkRoom
of the current domain. TheirtalkUsers
should be a list of all members of the talk.TODO
getUsers
getTalkRooms
[x] MakeWeb.Direct.Client.setCurrentDomain
updatesclientUsers
andclientTalkRooms
ofClient
direct4b get
To check the above fixes, I added
get
sub command todirect4b
command.Usage:
users
andtalks
accept-d DOMAIN_ID
option.