kakkun61 commented 5 years ago

This PR make a private RPC method removed.

I remove create_pair_talk RPC method from this public repository because it is a private one.

Original allocateChannel creates a pair talk in it, but it get not to be able to create a pair talk. And so new allocateChannel must be passed a talk to.

Breaking change

- withChannel :: Client -> ChannelType -> (Channel -> IO ()) -> IO Bool
+ withChannel :: Client -> TalkRoom -> Partner -> (Channel -> IO ()) -> IO Bool

withChannel never create talk rooms. Users must create a talk room before call withChannel and pass it.

talk room	partner	previously named
2 participants	one who participates	pair channel
2 participants	anyone	pair channel
many participants	one who participates	pin-point channel
many participants	anyone	group channel

restyled-io[bot] commented 5 years ago

Hey there-

I'm a bot, here to let you know that some code in this PR might not match the team's automated styling. I ran the team's auto-reformatting tools on the files changed in this PR and found some differences. Those differences can be seen in #83.

Please see that Pull Request's description for more details.

igrep commented 5 years ago

LGTM! IMG_20171224_090233

yotsuya commented 5 years ago

LGTM

restyled-io[bot] commented 5 years ago

Hey there-

I'm a bot, here to let you know that some code in this PR might not match the team's automated styling. I ran the team's auto-reformatting tools on the files changed in this PR and found some differences. Those differences can be seen in #84.

Please see that Pull Request's description for more details.

restyled-io[bot] commented 5 years ago

Hey there-

I'm a bot, here to let you know that some code in this PR might not match the team's automated styling. I ran the team's auto-reformatting tools on the files changed in this PR and found some differences. Those differences can be seen in #85.

Please see that Pull Request's description for more details.

restyled-io[bot] commented 5 years ago

Hey there-

I'm a bot, here to let you know that some code in this PR might not match the team's automated styling. I ran the team's auto-reformatting tools on the files changed in this PR and found some differences. Those differences can be seen in #86.

Please see that Pull Request's description for more details.

igrep commented 5 years ago

LGTM!

                                            ∧_∧::
(いいだろう、ただしビルドが通ったら、だ。)> 　(  ･_･  )::
                                      　 /⌒　　⌒)::
                                      　/ へ_＿/ /::
                                       (＿＼＼ﾐ)/::
                                      　 ｜ `-イ::
                                      　 /ｙ　 )::
                                      　/／　／::
                                       ／　／::
                                      (　く:::
                                      |＼ ヽ::  、

iijlab / direct-hs

Make a private RPC method removed #82

Breaking change