low-batt
commented
3 years ago Reproducing
To reproduce the crash:
-
Remove all files from the directory IINA is configured to store screenshots in (default "~/Pictures/Screenshots"). Be certain there aren't any files in the directory the finder hides by default such as
.DS_Store:low-batt@gag Screenshots$ ls -la total 16 drwx------ 3 low-batt staff 96 Jul 31 20:26 . drwx------+ 6 low-batt staff 192 Jul 31 19:48 .. -rw-r--r--@ 1 low-batt staff 6148 Jul 31 20:26 .DS_Store low-batt@gag Screenshots$This directory must be completely empty to reproduce the crash.
- Create a video with the filename "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789.mp4"
- Play the video
- Take a screenshot
An error message will be emitted to the mpv log:
[ 13.600][e][cplayer] Error opening '/Users/low-batt/Pictures/Screenshots/0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789-0001.png' for writing!
[ 13.600][e][cplayer] Error writing screenshot!IINA will then crash in Utility.getLatestScreenshot:
Full Crash Dump:
```text Process: IINA [10278] Path: /Users/USER/Library/Developer/Xcode/DerivedData/iina-echacgeisxgbwucwumppkhklmnkd/Build/Products/Release/IINA.app/Contents/MacOS/IINA Identifier: com.colliderli.iina Version: 1.2.0 (129) Code Type: X86-64 (Native) Parent Process: ??? [1] Responsible: IINA [10278] User ID: 503 Date/Time: 2021-07-29 20:47:46.801 -0400 OS Version: macOS 11.4 (20F71) Report Version: 12 Anonymous UUID: B893091E-94C0-4AAA-80D5-FE04EF46305A Time Awake Since Boot: 570000 seconds System Integrity Protection: enabled Crashed Thread: 17 Dispatch queue: com.colliderli.iina.controller Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Illegal instruction: 4 Termination Reason: Namespace SIGNAL, Code 0x4 Terminating Process: exc handler [10278] External Modification Warnings: Thread creation by external task. Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff202ec2ba mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff202ec62c mach_msg + 60 2 com.apple.CoreFoundation 0x00007fff2041a8c5 __CFRunLoopServiceMachPort + 316 3 com.apple.CoreFoundation 0x00007fff20418f7b __CFRunLoopRun + 1332 4 com.apple.CoreFoundation 0x00007fff20418380 CFRunLoopRunSpecific + 567 5 com.apple.HIToolbox 0x00007fff288b8ab3 RunCurrentEventLoopInMode + 292 6 com.apple.HIToolbox 0x00007fff288b8815 ReceiveNextEventCommon + 587 7 com.apple.HIToolbox 0x00007fff288b85b3 _BlockUntilNextEventMatchingListInModeWithFilter + 70 8 com.apple.AppKit 0x00007fff22b436f2 _DPSNextEvent + 864 9 com.apple.AppKit 0x00007fff22b41ec5 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1364 10 com.apple.AppKit 0x00007fff22b34239 -[NSApplication run] + 586 11 com.apple.AppKit 0x00007fff22b0847c NSApplicationMain + 816 12 com.colliderli.iina 0x0000000109437d49 main + 9 (AppDelegate.swift:22) 13 libdyld.dylib 0x00007fff2033cf5d start + 1 Thread 1:: mpv/mpv core 0 libsystem_kernel.dylib 0x00007fff202eecde __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fff20321e49 _pthread_cond_wait + 1298 2 libmpv.1.dylib 0x000000010eefbd09 mp_dispatch_queue_process + 345 3 libmpv.1.dylib 0x000000010ef386ce run_playloop + 2958 4 libmpv.1.dylib 0x000000010ef2e86c mp_play_files + 6860 5 libmpv.1.dylib 0x000000010ef1422e core_thread + 62 6 libsystem_pthread.dylib 0x00007fff203218fc _pthread_start + 224 7 libsystem_pthread.dylib 0x00007fff2031d443 thread_start + 15 Thread 2:: mpv/lua script (ytdl_hook) 0 libsystem_kernel.dylib 0x00007fff202eecde __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fff20321e49 _pthread_cond_wait + 1298 2 libmpv.1.dylib 0x000000010ef13a0f wait_wakeup + 95 3 libmpv.1.dylib 0x000000010ef143e5 mpv_wait_event + 357 4 libmpv.1.dylib 0x000000010ef303f6 script_wait_event + 102 5 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 6 liblua.5.1.dylib 0x000000010d41410c luaV_execute + 3514 7 liblua.5.1.dylib 0x000000010d40af19 luaD_call + 97 8 liblua.5.1.dylib 0x000000010d407550 lua_call + 41 9 libmpv.1.dylib 0x000000010ef2ff53 load_scripts + 291 10 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 11 liblua.5.1.dylib 0x000000010d40af08 luaD_call + 80 12 liblua.5.1.dylib 0x000000010d40a64f luaD_rawrunprotected + 84 13 liblua.5.1.dylib 0x000000010d40b180 luaD_pcall + 68 14 liblua.5.1.dylib 0x000000010d4075db lua_pcall + 105 15 libmpv.1.dylib 0x000000010ef2faeb run_lua + 1307 16 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 17 liblua.5.1.dylib 0x000000010d40af08 luaD_call + 80 18 liblua.5.1.dylib 0x000000010d40a64f luaD_rawrunprotected + 84 19 liblua.5.1.dylib 0x000000010d40b180 luaD_pcall + 68 20 liblua.5.1.dylib 0x000000010d40763f lua_cpcall + 45 21 libmpv.1.dylib 0x000000010ef2f533 load_lua + 147 22 libmpv.1.dylib 0x000000010ef3aba2 script_thread + 114 23 libsystem_pthread.dylib 0x00007fff203218fc _pthread_start + 224 24 libsystem_pthread.dylib 0x00007fff2031d443 thread_start + 15 Thread 3:: mpv/lua script (stats) 0 libsystem_kernel.dylib 0x00007fff202eecde __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fff20321e49 _pthread_cond_wait + 1298 2 libmpv.1.dylib 0x000000010ef13a0f wait_wakeup + 95 3 libmpv.1.dylib 0x000000010ef143e5 mpv_wait_event + 357 4 libmpv.1.dylib 0x000000010ef303f6 script_wait_event + 102 5 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 6 liblua.5.1.dylib 0x000000010d41410c luaV_execute + 3514 7 liblua.5.1.dylib 0x000000010d40af19 luaD_call + 97 8 liblua.5.1.dylib 0x000000010d407550 lua_call + 41 9 libmpv.1.dylib 0x000000010ef2ff53 load_scripts + 291 10 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 11 liblua.5.1.dylib 0x000000010d40af08 luaD_call + 80 12 liblua.5.1.dylib 0x000000010d40a64f luaD_rawrunprotected + 84 13 liblua.5.1.dylib 0x000000010d40b180 luaD_pcall + 68 14 liblua.5.1.dylib 0x000000010d4075db lua_pcall + 105 15 libmpv.1.dylib 0x000000010ef2faeb run_lua + 1307 16 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 17 liblua.5.1.dylib 0x000000010d40af08 luaD_call + 80 18 liblua.5.1.dylib 0x000000010d40a64f luaD_rawrunprotected + 84 19 liblua.5.1.dylib 0x000000010d40b180 luaD_pcall + 68 20 liblua.5.1.dylib 0x000000010d40763f lua_cpcall + 45 21 libmpv.1.dylib 0x000000010ef2f533 load_lua + 147 22 libmpv.1.dylib 0x000000010ef3aba2 script_thread + 114 23 libsystem_pthread.dylib 0x00007fff203218fc _pthread_start + 224 24 libsystem_pthread.dylib 0x00007fff2031d443 thread_start + 15 Thread 4:: mpv/lua script (console) 0 libsystem_kernel.dylib 0x00007fff202eecde __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fff20321e49 _pthread_cond_wait + 1298 2 libmpv.1.dylib 0x000000010ef13a0f wait_wakeup + 95 3 libmpv.1.dylib 0x000000010ef143e5 mpv_wait_event + 357 4 libmpv.1.dylib 0x000000010ef303f6 script_wait_event + 102 5 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 6 liblua.5.1.dylib 0x000000010d41410c luaV_execute + 3514 7 liblua.5.1.dylib 0x000000010d40af19 luaD_call + 97 8 liblua.5.1.dylib 0x000000010d407550 lua_call + 41 9 libmpv.1.dylib 0x000000010ef2ff53 load_scripts + 291 10 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 11 liblua.5.1.dylib 0x000000010d40af08 luaD_call + 80 12 liblua.5.1.dylib 0x000000010d40a64f luaD_rawrunprotected + 84 13 liblua.5.1.dylib 0x000000010d40b180 luaD_pcall + 68 14 liblua.5.1.dylib 0x000000010d4075db lua_pcall + 105 15 libmpv.1.dylib 0x000000010ef2faeb run_lua + 1307 16 liblua.5.1.dylib 0x000000010d40aab6 luaD_precall + 455 17 liblua.5.1.dylib 0x000000010d40af08 luaD_call + 80 18 liblua.5.1.dylib 0x000000010d40a64f luaD_rawrunprotected + 84 19 liblua.5.1.dylib 0x000000010d40b180 luaD_pcall + 68 20 liblua.5.1.dylib 0x000000010d40763f lua_cpcall + 45 21 libmpv.1.dylib 0x000000010ef2f533 load_lua + 147 22 libmpv.1.dylib 0x000000010ef3aba2 script_thread + 114 23 libsystem_pthread.dylib 0x00007fff203218fc _pthread_start + 224 24 libsystem_pthread.dylib 0x00007fff2031d443 thread_start + 15 Thread 5:: AMCP Logging Spool 0 libsystem_kernel.dylib 0x00007fff202ec2f6 semaphore_wait_trap + 10 1 com.apple.audio.caulk 0x00007fff286348da caulk::mach::semaphore::wait_or_error() + 16 2 com.apple.audio.caulk 0x00007fff28621836 caulk::semaphore::timed_wait(double) + 110 3 com.apple.audio.caulk 0x00007fff28621784 caulk::concurrent::details::worker_thread::run() + 30 4 com.apple.audio.caulk 0x00007fff28621502 void* caulk::thread_proxyAnalysis
The crash occurs on this line of Utility.getLatestScreenshot:
var latestFile: URL = contents[0]Since mpv was unable to save the screenshot the screenshot directory is still empty and therefore the contents array is empty and indexing into it triggers a crash.
Of course IINA should have noticed mpv failed to create the screenshot and should not be calling this method. IINA is submitting a command to mpv to take the screenshot asynchronously. The results of the command are returned as a mpv MPV_EVENT_COMMAND_REPLY event and processed in MPVController.handleEvent. The code in handleEvent does not check the event to see if mpv is reporting the command failed.
Fixing
The method MPVController.handleEvent needs to be changed to check if the event reports an error and if so, raise an alert. Unfortunately the mpv API does not provide any details on the failure. The error code returned maps to "error running command". The actual cause of the failure can only be found in the log files. All the alert can report is that IINA can not take a screenshot:
Even though the method Utility.getLatestScreenshot will no longer be called in this case it should be changed to guard against the directory being empty.
I will shortly post a pull request with these changes. This commit adds new text for the alert that will require localization.
Note that drewbitt encountered this failure when streaming. If it is common for streams to have filenames so long as to trigger this failure then IINA may want to consider how this situation can be improved. Although there is a workaround described below, many users may not think to investigate configuring mpv options as a solution to this failure.
Workaround
As lizyn showed in issue #3083, the mpv option screenshot-template can be used to configure the filename generated by mpv for screenshots. To workaround this failure set this option in IINA advanced preferences to something like "shot%n", a template that will does not include the long filename of the video:
Remember to restart IINA after setting this option.
The syntax of a mpv screenshot template is documented here: mpv manual screenshot-template option
saagarjha
This is a bug in mpv in crashing with long video titles since it saves files by default containing the full filename. macOS filename limit is 255 characters. But, streams can often have far more than 255 character filenames. Iina will then crash with no error display. This should be handled better, likely with an error display that it can't save a file. You could attempt to truncate this to 255 characters as well but that approach doesn't seem ideal.
and a crash
Expected Behavior: Tells you if it can't screenshot and doesn't simply crash with no error