iina / iina

The modern video player for macOS.
https://iina.io
GNU General Public License v3.0
38.01k stars 2.56k forks source link

Migrate from libmpv to libplacebo #5203

Open Foul-Tarnished opened 1 week ago

Foul-Tarnished commented 1 week ago

afaik, libmpv doesn't support Vulkan/MoltenVK, and is stuck with old OpenGL

Using LibPlacebo, we can get MoltenVK alongside proper HDR etc.

https://github.com/haasn/libplacebo

Foul-Tarnished commented 1 week ago

Until then, I guess mpv with gpu-next is superior to IINA

low-batt commented 1 week ago

Yes, there are many very desirable improvements in GPU Next that are not currently available to clients using libmpv.

At the moment IINA's plan is to wait for the mpv project to address issue https://github.com/mpv-player/mpv/issues/10810, "Support for libplacebo (gpu-next) in the rendering API".

Foul-Tarnished commented 1 week ago

Yes, there are many very desirable improvements in GPU Next that are not currently available to clients using libmpv.

At the moment IINA's plan is to wait for the mpv project to address issue mpv-player/mpv#10810, "Support for libplacebo (gpu-next) in the rendering API".

This issue seems to ask for gpu-next features in their opengl backend inside libmpv though ? Would be better to use macvk backend, that has gpu-next features, and is made for mac

low-batt commented 1 week ago

There was talk of a direct Metal implementation.

My sense is that the mpv project is still very focused on fixing gpu-next issues. For example mpv with --target-colorspace-hint crashes a lot of the time while quitting. So I've been keeping quiet and not pestering the mpv project on how they plan on exposing the new features to libmpv clients.

IINA has fallen behind and is currently focused on upgrading dependencies, adding support for new mpv features such as the additional controls on secondary subtitles and addressing some long standing technical debt. We are getting close to a beta release that contains these changes.