iina / iina

The modern video player for macOS.
https://iina.io
GNU General Public License v3.0
37.89k stars 2.56k forks source link

Bookmark feature #681

Open oillio opened 7 years ago

oillio commented 7 years ago

I would like to be able to set custom bookmarks within a file, and have them saved across multiple viewings.

Ideally, they would work just like chapters, except they are editable.

Kwadz commented 6 years ago

VLC offers the feature and stores the data in a m3u file.

iAPPOpen commented 5 years ago

VLC offers the feature and store the data in a m3u file.

PotPlayer也可以将书签单独存储为一个文件[.pbf],不过默认是存储在设置文件[.ini]中的,我觉得默认的方式非常不好,因为书签多了 ini 文件就会很臃肿,执行会非常卡,而pbf文件是一个视频对应一个pbf文件,就像外挂字幕一样,自动用视频的名字保存在视频同目录下,单独保存文件的方式非常好,载入性能大大提高,也方便编辑和备份,除了书签PotPlayer还可以将AB循环保存在文件中,这一点不错,有时候重复听视频中的音乐用这个方法不错

iAPPOpen commented 5 years ago

发现一个Elmedia player,看上去个方面都不错,也支持书签功能,但不能添加标题,VLC能添加标题但添加书签的方式很笨,还是继续等iina吧

ucdrstdenis commented 5 years ago

Please expedite this feature addition. There should be a straightforward method of inserting chapter markers into the .mp4 file

HarukaMa commented 5 years ago

@ucdrstdenis Inserting markers into the source file aka modifying input file is not something a player should do.

Maybe save them to dedicated files, but I'm not sure if storing it with the source file is good either. Inside Application Support?

NightMachinery commented 5 years ago

Saving besides the original file is actually great for portability.

On Tue, Feb 26, 2019 at 11:16 AM Haruka Ma notifications@github.com wrote:

@ucdrstdenis https://github.com/ucdrstdenis Inserting markers into the source file aka modifying input file is not something a player should do.

Maybe save them to dedicated files, but I'm not sure if storing it besides the source file is good either. Inside Application Support?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iina/iina/issues/681#issuecomment-467332091, or mute the thread https://github.com/notifications/unsubscribe-auth/Aii--u1v9FWUpQ-kngKGNX9jFOUYN7tNks5vROZtgaJpZM4NoZhR .

ucdrstdenis commented 5 years ago

@HarukaMa

Application support is perfect. Create a "bookmarked_files" folder in addition to the "watch_later" folder. Files included in both will have the same UUID file name

Kwadz commented 5 years ago

I think @NightMachinary is right. If we place the bookmark file in Application Support that means the bookmarks will work only on this computer. For example VLC use one file aside the video file for that. This way the user can easily choose to provide or not the bookmarks. Let's compare with a subtitles file, would you like it in Application Support? I think no. However for the "watch later" list this is related to parameters of the app, then this can be placed in Application Support. What do you think?

bitpit commented 5 years ago

I was pretty surprised to find this feature lacking in what has otherwise become my go to media player!

while seeing arguments for both Application Support and an adjacent m3u file or dat file, I might add that even an ephemeral session bookmarking capability could be quite useful depending on what you're viewing (eg something for transcription, something be used as source material for a written work, etc); and perhaps this ephemeral session bookmarking payload could be imported or exported, giving the user the choice of where to store the bookmarks (if they want to store them at all)

is this the sort of thing I could PR, or is there a process for feature additions? (I should probably try and find the contributors guidelines before blindly asking this hah)

yueyericardo commented 4 years ago

Is there any plan or progress on the bookmark?

Kwadz commented 4 years ago

I think since VLC 3.0, there is no reason to switch to another app. VLC is even better about performance while providing this feature among others.

vehovsky commented 4 years ago

You are saying that like VLC 3.0 was something new, it was around since Feb 9, 2018.

Anyway bookmarks you create in VLC are gone as soon as you close the app. Better Performance? Based on what metrics?

Kwadz commented 4 years ago

You need to save the bookmark you created. I mentioned the feature in this conversation at https://github.com/iina/iina/issues/681#issuecomment-468192535 and at https://github.com/iina/iina/issues/681#issuecomment-418956216.

About performance I saw #2219. Another benchmark is available here.

yueyericardo commented 4 years ago

I think since VLC 3.0, there is no reason to switch to another app. VLC is even better about performance while providing this feature among others.

But VLC has no shortcut to quickly creat a bookmark. You need to presscmd+b to open bookmarks window, then use mouse to add a bookmark.

Kwadz commented 4 years ago

Even if it's not perfect at least you have the feature...

vehovsky commented 4 years ago

I'm aware, but honestly having to explicitly save and then explicitly load the bookmarks... to me as good as no support at all.

yueyericardo commented 4 years ago

It’s better than nothing, but I still miss the way how potplayer does it.

vehovsky commented 4 years ago

Exactly in potplayer I was using it regularly. With VLC the feature was so bad that it wasn't worth the effort.

yueyericardo commented 4 years ago

The way how bookmark it does is awesome. (press b, automatically pause the video, you give a title or not, press enter, continue you video). But it’s only a chrome extension for YouTube.

NightMachinery commented 4 years ago

I was thinking of writing an mpv plugin, but never got to it. Do mpv plugins work with iina?

lhc70000 commented 4 years ago

IINA is expected to have a plugin system in 1.2.0. If you could wait for about 1-2 months, I think it may be better to write an IINA plugin directly.

juancpgo commented 4 years ago

I'm currently studying guitar by video in IINA. I also felt the desire for this feature. I would just add that I'd like also to be able to bookmark "AB" segments, because then I can loop those segments if I'm studying a guitar video for example.

I think both types of bookmarking would be very useful:

okerivy commented 4 years ago

iina need bookmarks , bookmarks is good in potplayer

wujita01 commented 3 years ago

wait for bookmarking just like in potplayer

caleidoscopio commented 2 years ago

This would be a great feature. The way VLC works is a bit clunky. CinePlayer has much better functionality, where you don't need to manually save the markers before you close the file and you can type a comment while the video is still playing back.

Immanuel-Aristotle commented 1 year ago

Is the bookmark feature now available?

birdjumper commented 4 months ago

I would also love a bookmark feature. For transcribing lengthy interviews, it would be useful.

MouJieQin commented 1 week ago

I partly completed this feature here Screen Recording 2024-09-29 at 01 39 07

MouJieQin commented 1 week ago

I'm currently studying guitar by video in IINA. I also felt the desire for this feature. I would just add that I'd like also to be able to bookmark "AB" segments, because then I can loop those segments if I'm studying a guitar video for example.

I think both types of bookmarking would be very useful:

  • "point" bookmarks, when I want to navigate quickly between several points in a video (like chapter marks); and also
  • segment bookmarks when I want to loop over segments when I'm learning something that demands frequent repetition.

I'm currently studying guitar too, and I completed these two features. See my comment.