search

iinegve / muCommander

muCommander fork
3 stars 5 forks source link

Fix known FindBugs issues #5

Open iinegve opened 11 years ago

iinegve commented 11 years ago

Run FindBug and fix known issues.

IvanMamontov commented 11 years ago

Could you please attach report to reproduce this issues?

iinegve commented 11 years ago

Here it is: https://gist.github.com/fathersson/5198808 But there is no way to get same worse than this. Well, you see, I don't want to fix everything that findbug has found, but most critical issues. Unfortunately it's not possible to see them in such a huge report. There is always a way to run findbug locally and fix whatever you think is supposed to be fixed.

But in general, we might need our own jenkins to run all kind of tools like findbug. Moreover, we require jenkins to run tests for "file" module.

iinegve commented 11 years ago

It doesn't mean it requires to fix everything findbug is able to find (it's just one such a tool, there are others). I just would like someone to run through the list and fix everything he assumes worth to fix.