search

iinsertNameHere / catnap

A highly customizable systemfetch written in nim
https://catnap-fetch.xyz
MIT License
174 stars 10 forks source link

Add support for custom location #147

Closed ruiiiijiiiiang closed 6 days ago

ruiiiijiiiiang commented 1 week ago

Is your pull request linked to an existing issue?

https://github.com/iinsertNameHere/catnap/issues/143

What is your pull request about?:

Allows user specified location for weather fetching.

iinsertNameHere commented 1 week ago

Hey, thx for your PR.. Unfortunately if you look at the tests, they failed to fetch the wether stat. I don't know why they did not fail, will open an issue an look into it..

ruiiiijiiiiang commented 6 days ago

Hi @iinsertNameHere, I figured out why the tests were failing. The test config location was "San Francisco", and the space was breaking the wttr.in url. I added a replace(" ", "+") as instructed by wttr.in and it is working now. As for the tests, I noticed that they were passing for me locally because the weather info was cached, so I added a -n to each test script to force a refresh. I'm still not sure why it was passing in the github workflow though, so you might need to further look into that.

iinsertNameHere commented 6 days ago

@ruiiiijiiiiang Thanks, for looking in to it!