[Assignment 2] Review

[minhchau273]

:+1: Great work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

• Functionality: Excellent
• Code Style: Good
• Visual Design: Excellent
• Usability: Excellent

  Overall: Excellent

  Detailed Notes

• Nice work specifying the Auto Layout constraints.
• Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
• Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.
• It's not a big deal but in case there is no result, you should show a label No results found to make your app more friendly :wink:
• It would be better if you save the last user's choices in the filters page.
• You should handle the case when the restaurant doesn't have the image, otherwise, your app will crash. You can test by searching with df keyword.
• It'd be better if you scrolled the table view to the top after returning from the filters page.

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work. 🏇

[minhchau273]

Looks like you haven't pushed the newest code to your repo yet. I still see the default switch in your app. And I don't see the infinite loading function as well.