search

iiordanov / remote-desktop-clients

VNC, RDP, SPICE, and oVirt/RHEV/Proxmox Clients for Android and Blackberry 10
GNU General Public License v3.0
2.1k stars 566 forks source link

Generate private key in iOS aRDP Pro app #566

Open mevdschee opened 3 months ago

mevdschee commented 3 months ago

Hi,

Thank you for the great software (aRDP Pro) that you have made. Our customers need to generate a private key on the device (for security reasons) and mail us the public key. In order to do so it would be great if there was a "generate private key" and "copy public key" buttons that generate and copy the ECDSA key. I hope you can add this to the iOS version (AFAIK the Android version already has such functionality). We tried copy-pasting the key, but people create wrong key types and also make mistakes with copy-pasting, leading to rejection of the SSH key.

Kind regards,

Joost and Maurits van der Schee

iiordanov commented 3 months ago

Hi @mevdschee this is a great feature request. In the meanwhile, as a workaround, a command like the following:

ssh-keygen -t ecdsa -f /tmp/keyfile1 -N ""

Will generate a key without a passphrase whose private part you can paste right into the application.

biggestsonicfan commented 1 week ago

Ah, was just trying to figure out where the key generation was and came across this issue. Good workaround.

EDIT: Forgive my ignorance, but is ssh-keygen done from a terminal and not the device itself?

EDIT2: The SSH keys I am using are instantly failing every time ...

EDIT3: I don't really like that I had to fish through closed issues to figure out I shouldn't be using RSA keys but ECDSA keys instead. I did manage to get in, but no sound was passed through and it ended up being a lot more difficult to use than expected for an RDP client.

iiordanov commented 6 days ago

Hi @biggestsonicfan, thanks for your feedback. Yes, it looks like RSA keys are on the phase-out on newer OpenSSH versions, and you have to do workarounds server-side to re-enable them nowadays. This is no fault of the app.

Yes, it's admittedly inconvenient to generate keys off-app, and that's why this feature request is open. There is just me working on the app at the moment, and the alternative to an inconvenience would be not having the app available altogether which I felt was worse.

As far as no sound is concerned, what are you connecting to? If it's xrdp, there are challenges with sound from a quick look https://unix.stackexchange.com/questions/620849/xrdp-sound-redirection-ubuntu-20-04 for a link to a blog post as well as instructions to kill (and restart) pulseaudio daemon with -k.

You know you can refund the app on the App Store any time, right? https://support.apple.com/en-ca/118223

Get in touch by email at support at morpheusly dot com if you want to join the Beta for free instead.

biggestsonicfan commented 5 days ago

I did end up going the refund route and I think it's mainly the 5th gen iPad's fault. I thought it might finally get some use through RDP but it looks like it's too clunky to handle it.