search

iipc / jwarc

Java library for reading and writing WARC files with a typed API
Apache License 2.0
46 stars 8 forks source link

Request/Response Builder with String targetURI #63

Closed robertvanloenhout closed 2 years ago

robertvanloenhout commented 2 years ago

Please add a constructor in the WarcRequest.Builder and the WarcResponse.Builder that accepts a String instead of a URI class. The internet is full of URI's that are difficult or impossible to parse to convert them to a URI class. Jwarc only calls targetURI.toString(), so this would be a small change.

ato commented 2 years ago

Feel free to submit a pull request with this change. :-)

robertvanloenhout commented 2 years ago

I have created a pull request at https://github.com/iipc/jwarc/pull/64