search

iipc / webarchive-commons

Common web archive utility code.
Apache License 2.0
49 stars 72 forks source link

Move missing unit tests over from Heritrix3 #73

Closed MohammedElsayyed closed 7 years ago

MohammedElsayyed commented 7 years ago

This fixes issue #25.

MohammedElsayyed commented 7 years ago

The following unit test already exists in webarchive-commons: /commons/src/test/java/org/archive/io/arc/ARCReaderFactoryTest.java

Because /modules/src/test/java/org/archive/modules/writer/ARCWriterProcessorTest.java /modules/src/test/java/org/archive/modules/writer/WARCWriterProcessorTest.java don't exits, I don't include them.

ldko commented 7 years ago

Thanks, Mohamed. This looks good to me. Thanks for doing the related Heritrix PR too! :+1:

MohammedElsayyed commented 7 years ago

I moved unit tests from iipc/Heritrix3 not from ia/Heritrix3, so what I am going to do is as follows:

  1. Make sure unit tests code-base moved to iipc/webarchive-commons are identical to ones in ia/Heritrix3.
  2. Recheck unit tests in ia/Heritrix3 which are not moved over to iipc/webarchive-commons. 2.1. If there are ones not moved over, then move them. 2.2. Open an issue in ia/Heritrix3 for deleting them. 2.3. Create a PR for removal.
MohammedElsayyed commented 7 years ago

I rechecked and everything is perfect :+1: