Choose an error code according to a failed priority setting

iipeace / guider

A Practically Applicable Performance Analyzer for Real Product Development

https://iipeace.github.io/docs/guider.html

GNU General Public License v2.0

629 stars 92 forks source link

Choose an error code according to a failed priority setting #265

Open elfring opened 3 years ago

elfring commented 3 years ago

The script “guider.py” contains the following source code at the moment.

…
        except:
            SysMgr.printErr((
                'fail to set the I/O schedling priority '
                'for %s(%s) to %s(%s)[%s]') % \
                    (comm, pid, ioclass, pri, nmWho), True)
            sys.exit(0)
…

I suggest to use the text “failed to set the I/O scheduling priority” instead.
Would you like to pass a more appropriate error code to the exit method call?

iipeace commented 3 years ago

I completely agree with you ;(