iissnan / hexo-theme-next

Elegant theme for Hexo.
http://notes.iissnan.com
MIT License
15.87k stars 3.62k forks source link

Make hyper comment visible #1718

Closed Gabirel closed 7 years ago

Gabirel commented 7 years ago

Expected behavior (预期行为)

I want my comment area to be visible. Is there any way to do that?

@ivan-nginx I guess I need your help

Actual behavior (实际行为)

Yes, my blog's background color is black image

image

Steps to reproduce the behavior (重现步骤)

NexT Information

Add the ✔ sign before an item which is affected by this behavior.

NexT Version:

NexT Scheme: My customized black scheme ✔

Other Information (Like Browser, System, Screenshots)

Gabirel commented 7 years ago

I'm sorry. I am so stupid that I forget importing customized stylus into index.styl.

I'm working on it.

Gabirel commented 7 years ago

image Adding these should do the job.

Close it

ivan-nginx commented 7 years ago

@Gabirel can u make pull with this if this is bug?

Gabirel commented 7 years ago

@ivan-nginx I'm sorry that I can't do that.

Why?

NexT Scheme: My customized black scheme ✔

So, this change doesn't work for your blog since your blog's bg color is white. But, I just made another scheme called Mala, which this bg color is black. So, that's not a fatal bug for all users.

Gabirel commented 7 years ago

Oh, BTW, I can submit a Pull Request to this repo only if official black scheme comes out

ivan-nginx commented 7 years ago

Oh, i see. But there is global var for background color, right? In source/css/_variables/custom.styl

$body-bg-color = #ededed;
ivan-nginx commented 7 years ago

@Gabirel what scheme is this?


Ok, i see. This scheme based on Mist, right? And on your blog i see three_waves plugin or something like this. This is by default in this scheme or not?


U can do pull request and we will see how it looks, i think. More schemes — also gooder.

Gabirel commented 7 years ago

Yes, it's true.

However, I've make a lot of changes in my schemes. Not just changed the $body-bg-color.

I've re-designed based on @idhyt 's hexo-theme-next. This repo has black themes which he calls it Mala(just like Mist, Muse, and Pisces).

Since his blog's theme seems to never keep updated with upstream(hexo-next-theme), his theme of blog is too old. And also, too much I don't like and not good for developers. So I based on latest version of hexo-next-theme and his Mala scheme to finish my Mala scheme.

Totally compatible with official hexo-next-theme. So, that's Mala scheme. You can see it in here.

My file structure: image

ivan-nginx commented 7 years ago

@Gabirel ok, this is good. Many peoples want to use black scheme and i think need to pull request from you.

Gabirel commented 7 years ago

Umm...It's OK for me though. But, how do you do that? I've forked from idhyt/hexo-theme-next. But his repo doesn't have any relationships with this repo(upstream). So do I.

Also, making a theme(including front-end stuff) isn't my speciality. I don't have any warranty

ivan-nginx commented 7 years ago

@Gabirel yeah, this is called «work». Need to clone original repo and then need to compare all changes from your repo and find/make changes to «Mala» scheme. Afterthat — make pull. For compare files need some programs/utilites. If u use Windows, u can use program called «Beyond Compare». If u use Mac or Linux, u can find program like that. Something like «program to compare file changes». It's like compare on GitHub, but local program. Or, u may use standart GitHub compare too, but it's hardly.

ivan-nginx commented 7 years ago

@Gabirel ok, for now a have not enough time and try to do it later.


Thanks for discussion.