Closed rakaar closed 4 years ago
@thealphadollar , I chose the logo because I felt that would look good when the link is shared, as it does not have a plain background. Okay will update with the latest as per the current facebook profile pic.
Please update it.
On Wed, Nov 6, 2019 at 2:37 PM Raghavendra Kaushik notifications@github.com wrote:
@thealphadollar https://github.com/thealphadollar , I chose the logo because I felt that would look good when the link is shared, as it does not have a plain background. Okay will update with the latest as per the current facebook profile pic.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iit-technology-ambit/Apsara2.0/pull/27?email_source=notifications&email_token=AH2K2IG3FLOH5AO622G4BX3QSKCOHA5CNFSM4JI5G7B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFZ6RQ#issuecomment-550215494, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2K2ICGICIHGOTUQWDT5UTQSKCOHANCNFSM4JI5G7BQ .
We cannot test it with ngrok. I think deployment is the only way to check.
In the tags the images refered to icon.png which wasn't there at all. So, downloaded a new pic from facebook profile pics, and named it as icon.jpg and changed accordingly in the meta tags. I believe this should work also seen the same thing here
fixes #5