iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

can't install local plugins #1120

Open timriker opened 8 years ago

timriker commented 8 years ago

Running ITC 0.25.1 on a Galaxy S4 running Cyanogenmod 12.1 (Android 5.1.1).

Starting the app and trying to select a local plugin. The directory listed for local plugins is:

/storage/emulated/0/IITC_Mobile/plugins/

/storage/emulated is on the compressed root partition and not editible. there is no "0" here. there is a legacy link to the current:

legacy -> /mnt/shell/emulated/0

I try selecting plugins that end in .user.js from Downloads and from a Google Drive. It won't select any. I expect that's because the target directory does not exist? No message is displayed though, and there does not appear to be a setting to select an alternate path. A better choice might be:

/sdcard/IITC_Mobile/plugins/

which should exist on more devices and Android versions.

FesterCluck commented 8 years ago

Actually, this has to do with file type associations. Do this: Download one of the plugin user.js scripts manually through the browser, then attempt to open it. Or, try a file explorer. If the file immediately opens up in any program other than IITCm you'll need to remove that association. It doesn't have to be associated with IITCm, just leave it to ask each time.

timriker commented 8 years ago

I guess I was not clear. The issue is that the, apparently hard coded, path does not exist. There is no:

/storage/emulated/0/

When I try to open a *.user.js file in ES File Explorer, it asks for an application, and offers to make that selection permanent. I did NOT make any application permanent.

Meanwhile, the directory for plugins, does not exist and the parent directory does not exist, so it can't be created. The parent is in the kernel filesystem, so I can't remount it and create that either.

FesterCluck commented 8 years ago

@timriker There is a switch in IITCm called Developer Mode which will allow for that path to be changed. /storage/emulated/0 exists when you have a microSD card in your phone. The developer mode setting allows for loading scripts from it. You should probably turn that setting off.

timriker commented 7 years ago

As explained above, I do have an sdcard in my phone, and I do NOT have a /storage/emulated/0

So your assumption that the directory exists, is false for at least my phone, don't know how many others.

FesterCluck commented 7 years ago

Yes. That's the documented way an sdcard is mounted in android.

There is a feature that merges your sdcard with the main one, in which case we can't tell the difference.

If this isn't the case we'd appreciate you letting us know what the mount point is.

On Mar 3, 2017 3:59 PM, "Tim Riker" notifications@github.com wrote:

As explained above, I do have an sdcard in my phone, and I do NOT have a /storage/emulated/0

So your assumption that the directory exists, is false for at least my phone, don't know how many others.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iitc-project/ingress-intel-total-conversion/issues/1120#issuecomment-284081813, or mute the thread https://github.com/notifications/unsubscribe-auth/AADProhh4yXke1PI4wYqP9x-dcBlJKq8ks5riI1ZgaJpZM4JROep .

FesterCluck commented 7 years ago

Yes. That's the documented way an sdcard is mounted in android.

There is a feature that merges your sdcard with the main one, in which case we can't tell the difference.

If this isn't the case we'd appreciate you letting us know what the mount point is.

On Mar 3, 2017 3:59 PM, "Tim Riker" notifications@github.com wrote:

As explained above, I do have an sdcard in my phone, and I do NOT have a /storage/emulated/0

So your assumption that the directory exists, is false for at least my phone, don't know how many others.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iitc-project/ingress-intel-total-conversion/issues/1120#issuecomment-284081813, or mute the thread https://github.com/notifications/unsubscribe-auth/AADProhh4yXke1PI4wYqP9x-dcBlJKq8ks5riI1ZgaJpZM4JROep .