search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

Remove customizations of third-party code #1165

Open dingram opened 7 years ago

dingram commented 7 years ago

Various third-party libraries used by IITC have been customized in one way or another. These customizations should either be submitted upstream, pulled out in some way, or monkey-patched (as a last resort).

Having modified third-party code in the main repository makes it very hard to upgrade, and also means that the final JS is much larger than it strictly needs to be.

McBen commented 7 years ago

sounds good, but not possible or viable.

Example 1: in leaflet & leaflet.draw the value of the earth radius was changed to reflect the simpler values used by Nia.

Example 2: in most css files image references where replaced by the @@IMAGE@@ build makro. okay. This could be easily be moved into an extra css but would again break on a library update.

IMHO its better to make clear that these files were modified.
A simple file-rename could warn developers ("leaflet-src.js" -> "leaflet-src-mod.js") Additional as developer rule: always commit the unmodified version first then commit modifications. This way you have a nice git log what and why was modified.

McBen commented 7 years ago

as an example: PR #1168 it was (nearly) done be simply cherrypick the old modifications.

I just skipped the 'rename the file' part.

johnd0e commented 5 years ago

@McBen