search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

Plugin: Bookmarks for maps and portals (bookmarks-by-zaso) #1170

Open Novoca1n3 opened 7 years ago

Novoca1n3 commented 7 years ago

Any possibility of adding the ability to import KML files? Similar to the overlay KML plug-in however they are stored as bookmarks instead of an overlay

nhamer commented 7 years ago

You should probably contact Zaso directly (he's a friendly type) at https://github.com/ZasoGD

Novoca1n3 commented 7 years ago

Thanks

Get Outlook for Androidhttps://aka.ms/ghei36

On Fri, Jan 6, 2017 at 6:34 PM +1100, "nhamer" notifications@github.com<mailto:notifications@github.com> wrote:

You should probably contact Zaso directly (he's a friendly type) at https://github.com/ZasoGD

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/iitc-project/ingress-intel-total-conversion/issues/1170#issuecomment-270848446, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXylv-oKGrOcttkWWcuL-QKMhsnfCgHwks5rPe57gaJpZM4LcMZv.

nhamer commented 7 years ago

@zasogd may correct me, but thinking about it - imported bookmarks need portal GUIDs, which you aren't going to find in KML.

Novoca1n3 commented 7 years ago

I can import KML now and have it put location markers on portals therefore all the required information must already exist. Attached is an example KML file

Get Outlook for Androidhttps://aka.ms/ghei36

On Sat, Jan 21, 2017 at 3:47 PM +1100, "nhamer" notifications@github.com<mailto:notifications@github.com> wrote:

@zasogdhttps://github.com/zasogd may correct me, but thinking about it - imported bookmarks need portal GUIDs, which you aren't going to find in KML.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/iitc-project/ingress-intel-total-conversion/issues/1170#issuecomment-274235417, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXylvyA7JqmBsokzvACjJgl4L8vyx3FKks5rUY3XgaJpZM4LcMZv.

nhamer commented 7 years ago

Can you upload the kml either directly here to github or to pastebin or something? It didn't come through in mail.

On Fri, Jan 20, 2017 at 10:02 PM, whartyENL notifications@github.com wrote:

I can import KML now and have it put location markers on portals therefore all the required information must already exist. Attached is an example KML file

Get Outlook for Androidhttps://aka.ms/ghei36

On Sat, Jan 21, 2017 at 3:47 PM +1100, "nhamer" <notifications@github.com< mailto:notifications@github.com>> wrote:

@zasogdhttps://github.com/zasogd may correct me, but thinking about it

  • imported bookmarks need portal GUIDs, which you aren't going to find in KML.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ iitc-project/ingress-intel-total-conversion/issues/1170# issuecomment-274235417, or mute the threadhttps://github.com/ notifications/unsubscribe-auth/AXylvyA7JqmBsokzvACjJgl4L8vyx3 FKks5rUY3XgaJpZM4LcMZv.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iitc-project/ingress-intel-total-conversion/issues/1170#issuecomment-274239652, or mute the thread https://github.com/notifications/unsubscribe-auth/AXzED324ANTdxA0vCL8f-i3TKGuDlfLEks5rUZ9ZgaJpZM4LcMZv .

Novoca1n3 commented 7 years ago

Silly question, how do I add attachments :-)

nhamer commented 7 years ago

Oh. I suppose the answer is actually "upload to pastebin, add a link". Sorry, just getting used to the toolchain.

ZasoGD commented 7 years ago

In IITC A portal can be found without using its GUID window.selectPortalByLatLng(lat, lng).

If you have not the GUID is not a problem (you can create a fake GUID when you add/create one o more portal(s) in bookmarks), but bookmarks when you click a portal bookmark from the list uses the window.zoomToAndShowPortal(guid, latlng) to move the map and select the portal. Furthermore, without the GUIDs the star not works properly.

It's not possible import correctly KML data in bookmarks if in the KML are not the GUID of portals.

Why don't edit the plugin? I'll open an issue about this (I hope that @nhamer and others will want to partecipate).

Novoca1n3 commented 7 years ago

Here's an example KML file created by exporting from google maps. It contains ingress portals for overlay in IITC http://pastebin.com/rPiEAaGk

nhamer commented 7 years ago

Yeah, no GUIDs. So essentially, highlight can't work, star can't work. I suppose you could create a fake GUID on import, but the limitation is going to be confusing.

What's your use case here? It would seem more natural to import KML to e.g. drawtools.

Novoca1n3 commented 7 years ago

These kml files overlay portals in IITC (using the Overlay KML plugin) making it easy to locate and navigate to them. The problem is that when iitc is closed, you need to load the file again. Saving as bookmarks means they would stay loaded and be synced between devices

nhamer commented 7 years ago

Ref. #1154 possibly - possibly overlay-kml should persist a kml and handle network-links? I wasn't aware it didn't even save the KML between sessions (that's dum), but network links would also keep it current (not even using sync plugins)?

Novoca1n3 commented 7 years ago

If you're sharing files between people I think you may need a shared network location to link too. Not sure as I've never tried it