iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

Softbank Ultralink - Defense boost not shown #1239

Open thatcode opened 7 years ago

thatcode commented 7 years ago

2 portals, both with 12 links, show 60 defence bonus from links. This is correct :)

However, 1 of these portals has an SBUL attached, and so should be showing 90 defence bonus from links alone.

Images attached. no-sbul sbul

nhamer commented 7 years ago

Has anybody figured out whether the defense boost stacks? We have the defense boost in mod data, but yeah, it's ignored when calculating mitigation.

auguchanan commented 6 years ago

Has anybody figured out whether the defense boost stacks? We have the defense boost in mod data, but yeah, it's ignored when calculating mitigation.

The stacking is multiplicative as shown by the screenshot below for two and three SoftBank Ultra Links (1.5 ^ 2 = 2.25 ≈ 2.3 and 1.5 ^ 3 = 3.375 ≈ 3.4 = 2.3 + 1.1). screenshot_20180217-122819

I've created a pull request #1257 fashioned after the pull request #1243 but by using multiplicative stacking instead of additive stacking to address this issue.