search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

IITC Mobile and plugins - bad positions #236

Closed jonatkins closed 11 years ago

jonatkins commented 11 years ago

The following plugins have issues with positioning on IITC Mobile

scale-bar pan-control zoom-slider

(and the existing zoom buttons could be positioned better too)

leCradle commented 11 years ago

The developers of these plugins can use the developer mode of iitc mobile introduced in v0.3.3 (the new test builds should include it http://iitc.jonatkins.com/?page=test) to test their plugins on iitc mobile. Just copy all compiled iitc sources to <storage-path>/IITC-Mobile/dev/ on your Android device and enable the developer mode in the iitcm settings. This way you can easily update your script and check if it works as it should on iitcm.

Maybe @Fragger can have a look at the pan-control and the zoom-slider?

vita10gy commented 11 years ago

Wouldn't be a bad idea to somehow denote the plugin isn't mobile ready/compatible so it just isn't an option.

My scoreboard one doesn't size very well, for example. It's possible/likely these things can't be solved by simple css changes. We might need completely different versions of them for mobile.

leCradle commented 11 years ago

@vita10gy Yes...that is the reason for this issue post. I am thinking about removing all not working / not well working / not needed plugins from the build....

For example force-https is redundant on iitcm...the app does this out of box. Furthermore, the privacy plugin is not working and not needed on iitcm, because there's nothing privacy-related on the map view... These 2 plugins will definitely be removed from build... Regarding the other plugins...I think it should be not a big problem to fix them...and since no one is forced to use them atm and iitcm is still labeled as beta, it should be ok to keep them.

ghost commented 11 years ago

I've also problems with the draw plugin. I can draw, but after a few lines it's getting messy.

Fragger commented 11 years ago

To make this easy the build system should probably be updated to look for a no mobile flag in the plugin header and not copy it to the mobile source if that is found.

I'll try and get around to checking out the css in the couple plugins I did to make them work better on mobile soon, just moved back home after finals for the summer and I'm still unpacking :)

jonatkins commented 11 years ago

scale bar is now OK, with specific mobile positioning.

The other two could be good now too, since the removal of the in-web tabs for switching views.

hastarin commented 11 years ago

Yes I've tweaked most of those now. They shouldn't be too bad, especially once #267 is merged.

leCradle commented 11 years ago

The new draw plugin works pretty well on mobile. It is possible to hide the 'add circle' feature on mobile? Because click and drag will not work...

jonatkins commented 11 years ago

@leCradle there's more than just the 'circle' tool that's broken on mobile. editing is practically impossible as it also relies on dragging. And I had a lot of trouble reliably tapping on a polygon end point to close it - ending up with multiple duplicate points very close together.

Anyway, that's a separate issue. Positions seem OK now, so I'll close this one.