search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

mobile zoom #271

Closed vita10gy closed 11 years ago

vita10gy commented 11 years ago

Using the current test build on mobile I got stuck zoomed way in on level undefined. After a dozen attempts or so it eventually zoomed all the way out to mars and said level impossible.

Nexus 4

Not sure it this is the same as the other zoom issues

hastarin commented 11 years ago

Were you using pinch to zoom or the +/- controls?

vita10gy commented 11 years ago

Pinch. +/- disabled

hastarin commented 11 years ago

PS Try disabling all plugins to see if that helps. Assuming the test build has the leaflet update things should be better not worse on most mobiles.

vita10gy commented 11 years ago

ITC Mobile version 0.3.6, with IITC version 0.12.0.20130512.163204

vita10gy commented 11 years ago

Also, in general it's fine. Just got stuck in that.

jonatkins commented 11 years ago

Not sure how you got to level 'undefined' - shouldn't be possible at all.

The level 'impossible' was a bug - a3b957c96756b674495eacb8d85a66865649f624 fixes it

There were also issues with unnecessary requests for portals outside the valid +-180 +-90 degree region - also fixed

leCradle commented 11 years ago

@jonatkins seems that the level 'undefined' bug is not fixed yet. Here and there I get this msg too...also on git HEAD.

vita10gy commented 11 years ago

I just got it to say Lundefined using the newest build on the test page. Mobile. Nexus 7. was pinching to zoom, +/- on.

jonatkins commented 11 years ago

OK, I finally figured out the likely cause of Lundefined. the Leaflet map.getZoom() function is returning a floating point value! Floating point indexes into arrays return undefined, giving this problem.