search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

Guess Player Levels plugin may have incorrect results after Jarvis Viris/Ada Refactor #326

Closed jonatkins closed 11 years ago

jonatkins commented 11 years ago

The Jarvis Virus/Ada Refactor set the ownership of the portal and all resonators to the player that used it.

This breaks the assumption that the player will not own a resonator higher than their own level.

ZZJHONS commented 11 years ago

Then put something that check the owner of the portal and if it is JARVIS (or ADA refactor nick) don't count that resonators, understand? El 27/05/2013 16:12, "Jon Atkins" notifications@github.com escribió:

The Jarvis Virus/Ada Refactor set the ownership of the portal and all resonators to the player that used it.

This breaks the assumption that the player will not own a resonator higher than their own level.

— Reply to this email directly or view it on GitHubhttps://github.com/jonatkins/ingress-intel-total-conversion/issues/326 .

jonatkins commented 11 years ago

Is this still the case? I know the portal and resonators were first owned by those accounts, but thought they changed it?

Another option, which isn't perfect but does help, is to ignore portals with impossible deployments - more than 1 L8/7, more than 2 L6/5, etc owned by one player.

jonatkins commented 11 years ago

OK, I've had it confirmed by an agent I know.

If you use the item that turns a portal to the opposite faction, everything is owned by JARVIS or ADA

If you use it to turn a portal to your OWN faction, everything is owned by the user.

This includes the portal ownership, all shield mods, and all resonators.

The case with ownership by ADA or JARVIS won't be an issue - but we'll need to add code to ignore impossible deployments. It won't be perfect, but will catch the more-likely cases of their use.

waldos commented 11 years ago

One condition can be: if one player has 2 L8, 2 L7 or 3 L6, etc, this portal is ADA/JARVIS

waldos commented 11 years ago

Nice :+1:

vita10gy commented 11 years ago

I don't suppose we're lucky enough that buried in the data somewhere is a straight up yes/no if it has been infected?

vita10gy commented 11 years ago

By the way, I'm seeing level 8's and such all over, where I know for a fact they aren't, so this was a valiant effort, but I think we might have to wipe the slate and watch actual so-and-so deployed messages if there's no real way to tell a portal was flipped by a virus.

Even though that will obviously be must less robust, at least we'll know what we know that way. As it stands it only has to be wrong once to be wrong always.