Bookmark plugin does not work well

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.

http://iitc.jonatkins.com/

ISC License

991 stars 552 forks source link

Bookmark plugin does not work well #357

Closed leCradle closed 11 years ago

leCradle commented 11 years ago

I have tested the plugin on Chromium, Firefox and Mobile:

On Chromium I can add portals, but I can't add maps and folders.
On Firefox I can add maps, but I can't add portals and folders.
On Mobile I can add folders, sometimes I can add maps, but I can't add portals.
As mentioned in the commit msg, the background is broken.
An API would be great, because I am thinking about making bookmarks an in-app feature...

Just opened this issue for discussion and to keep track, because bookmarks are a great idea. @jonatkins can you contact the author of this plugin to join us here on github?

jonatkins commented 11 years ago

ffbf82a44eef818dca66be14a6d7023f10803898 is the new version - split files from the author

tb52s7 commented 11 years ago

First let me say, I love love love this plugin concept. I have only used it for mobile so let me relate my experience:

I just installed the latest-as-of-right-now test build, and bookmarks doesn't work at all. The trigger does not appear on the screen.

In last night's test build, saving maps was working, and after several minutes of fiddling with it and restarting IITC each I was able to save three portals, but the much bigger problem is that my previously saved maps and portals were disappearing to show a blank list. I would then have to restart IITC to get the previously saved maps and portals back on the list, which eventually would disappear again fairly quickly.

I'm reverting back to last night's build. Bookmarks will be an amazing tool once it works right.

ZasoGD commented 11 years ago

Hello to all. I'm the author of the plugin.

The background is fixed with last plugin version;
On Firefox (win7) I can to add folders,portals and maps, but tomorrow I'll do some more tests;
On Firefox: click event error when ending bookmark sort (fixed with next update);
For API... I never done such a thing. I'll study a way.
I've never tried the plugin on mobile. I have written it for browser. I hope soon to be able to make it work on Mobile;

In the coming days I hope to do everything possible. Thanks for your opinion

leCradle commented 11 years ago

@ZasoGD nice...good to get in contact with you. The latest version fixes all problems on desktop. But I can't see the bookmark flag on mobile anymore. But nevermind...if we made this in-app we don't need a css for mobile.

leCradle commented 11 years ago

Regarding the API...I have to think about this too...at the moment I don't think that it will straight forward to implement that stuff on android... Maybe it will be easier to implement the whole plugin natively...but yeah...I have to think about this first...maybe you want to focus at the other stuff first... ;)

tb52s7 commented 11 years ago

Here's another bug in last night's mobile test build:

When I'm in chat and I pop up my keypad, not only do I see the bookmark trigger, but part of the bookmark dialog occupies a line of text.

I think the bookmark plugin should avoid displaying on any screen other than the map.

Edit: Although, having bookmarks on the info screen would be good too, I just don't particularly care for how the trigger blocks the view of a little information.

leCradle commented 11 years ago

After this patch on the wrapper function, the plugin works again on mobile, but...it seems to have a problem when the bookmarks are updated (after adding a map/portal bookmark). After updating, all bookmarks disappear... @ZasoGD any ideas? After a reload, it works again.

ZasoGD commented 11 years ago

To me the plugin doesn't work on mobile. However, I'm editing the plugin to optimize it for mobile. The bookmarks box will load in the sidebar (not in desktop mode). I'm almost done.

leCradle commented 11 years ago

Well...it should work....did you include my wrapper function patch? IITC Mobile can only load plugins if the wrapper function and the injection code is identical to all other plugins.