search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

IITC Mobile fails to initialise javascript in some cases #437

Closed jonatkins closed 11 years ago

jonatkins commented 11 years ago

It results in this: image

It's known to happen when 'force Desktop mode' is enabled.

Also, I've been getting it recently when following a URL with ll and z parameters to set an initial map view. e.g. https://www.ingress.com/intel?ll=51.351423,0.740815&z=18

leCradle commented 11 years ago

Did your build include this patch https://github.com/jonatkins/ingress-intel-total-conversion/commit/9663df105fd6bb45e5d531302ae310b7f9e25d05 ?

jonatkins commented 11 years ago

OK, that does fix the 'force desktop' case, yes - with the side effect of seeing the stock map for a few seconds first.

Still get the issues when following links with coordinates in them. They were httpsa links, but i have 'https' mode disabled, if it makes a difference. Connected via WiFi on a Nexus 7, with things set to mobile (not desktop) mode.

leCradle commented 11 years ago

@jonatkins maybe it is time to get rid of the WebRessourceResponse injecting since iitc seems to be injected too early with this method. I pushed an alternative suggestion. Inject the script onPageFinished()...block all niantic ressources (should hide the vanilla intel map) and show some kind of splash screen while loading. The splash screen is hidden after iitc boot (see the boot.js modification)... The splash screen image could be tweaked...showing "IITC Mobile" instead of just "IITC" or something, but I am not really good at graphic stuff...maybe someone else could do this (if my suggestion is accepted). Please check if it fixes your issue on mobile view, because I can't reproduce it..

jonatkins commented 11 years ago

all seems good now - and nice loading screen too