iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

Requests differ, IITC easy to detect #619

Closed macrojames closed 9 years ago

macrojames commented 10 years ago

I see different request payloads for stock and iitc. I think this could be an issue.

Please ignore the different tilesets. I have never seen "desiredNumItems" before in getThinnedEntities

Stock:

{
    "6vcl0ivqz4aj5sfu": [
        "3_9602_6756",
        "3_9624_6755"
    ],
    "6jd5b49wn748diye": 74,
    "891ebsryg45b8cxb": -90000000,
    "mvepdcx1k6noya15": -180000000,
    "s3rh3fhji5mcjlof": 90000000,
    "yqdgfuukrxj8byzj": 180000000,
    "btf0kpztxrkt6sl6": 0,
    "hg8vhtehxf53n5cu": 1383119552927,
    "wg7gyxoanqc1si5r": "18lmw7lytgxji0dk",
    "adlo9o4kjvho5q94": "56036a6497ea344a9fffa38b171a77c092c1f220"
}

IITC:

{
    "wg7gyxoanqc1si5r": "18lmw7lytgxji0dk",
    "adlo9o4kjvho5q94": "56036a6497ea344a9fffa38b171a77c092c1f220",
    "6vcl0ivqz4aj5sfu": [
        "3_9619_6757",
        "3_9606_6755",
        "3_9627_6755",
        "3_9617_6755",
        "3_9613_6757",
        "3_9616_6754",
        "3_9604_6754",
        "3_9614_6756",
        "3_9623_6753",
        "3_9612_6756",
        "3_9627_6759",
        "3_9603_6755",
        "3_9601_6757",
        "3_9611_6759",
        "3_9608_6757",
        "3_9610_6754",
        "3_9616_6755",
        "3_9624_6759",
        "3_9619_6756",
        "3_9626_6754",
        "3_9625_6754",
        "3_9612_6758",
        "3_9612_6757",
        "3_9627_6753",
        "3_9620_6756",
        "3_9619_6753",
        "3_9603_6757",
        "3_9604_6756",
        "3_9611_6755",
        "3_9614_6758",
        "3_9623_6759",
        "3_9616_6756"
    ]
}
jonatkins commented 10 years ago

IITC isn't intended to be hard to detect. Our most obvious difference is requesting more entries from COMM than the standard site does, due to our taller window and COMM filtering into separate tabs.

These odd extra parameters come from some daft attempts at request obsfucation in the standard site, where the code adds in extra dummy parameters to every request. Search the standard gen_dashboard.js for nemesis.dashboard.network.DataFetcher.normalizeParamCount

jonatkins commented 10 years ago

Given the recent set of user bans, where a trusted source has passed on reasons such as "Excessive Intel Use" and "3rd party Intel program" for being banned, I've decided to revisit this.

jonatkins commented 10 years ago

As of commit 47d453793c95fb1a68c45d800d0dd61ada7c6f97, and test builds dated after 2013-11-24 01:52:00 UTC, things have been changed to follow the standard intel site in request formats.

I'm still comparing the two, seeing if there's other changes that should be made. #656 is also relevant

nexushoratio commented 9 years ago

Is there anything left to do for this issue?