search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

Issue: Update check reference version not updating? #637

Closed cathesaurus closed 10 years ago

cathesaurus commented 10 years ago

Have just installed latest test build, 0.9.30.foo, and Update Check tells me that the installed version is more recent than the latest version, 0.9.16.foo. It's been giving that as the latest version for the last few days. At first, I thought it was checking against the latest official release version, but that's even earlier. I realise Update Check is work in progress, but just letting you know.

jonatkins commented 10 years ago

I'm going to assume mobile here, as 0.9.xxx wouldn't make sense for the desktop version number.

Just to confirm - you're running the current test builds downloaded from the website - http://iitc.jonatkins.com/?page=test? Not building a version from source yourself? Local builds are not supported for version checking - doesn't make sense - and I probably haven't caught these error cases yet.

But assuming you are running the test build - odd! Are 0.9.30.foo and 0.9.16.foo the actual version numbers concerned? As that number is the git commit count for the build, and is currently 2530. (the final bit of the version string is the git commit hash for the build, and is also useful)

The version check retrieves the latest build date from the URL http://iitc.jonatkins.com/devsite/versioncheck.php?build=jonatkins-test&mobile=1 (or ...mobile=0 for desktop) - and this PHP script dynamically reads the version details from the .apk file on disk.

Assuming none of the above helps track down the issue, the full contents of the version check dialog could be useful - a screenshot will do.

cathesaurus commented 10 years ago

Mobile, yes. I only download test builds from the site. (My own builds are for the IITC Mobile variant, which I never download from the site.)

foo was me being lazy, sorry - the currently installed version is 0.9.2530.17fda5f, available version 0.9.2516.9a4efad.

On 11 Nov 2013, at 05:17, Jon Atkins notifications@github.com wrote:

I'm going to assume mobile here, as 0.9.xxx wouldn't make sense for the desktop version number.

Just to confirm - you're running the current test builds downloaded from the website - http://iitc.jonatkins.com/?page=test? Not building a version from source yourself? Local builds are not supported for version checking - doesn't make sense - and I probably haven't caught these error cases yet.

But assuming you are running the test build - odd! Are 0.9.30.foo and 0.9.16.foo the actual version numbers concerned? As that number is the git commit count for the build, and is currently 2530. (the final bit of the version string is the git commit hash for the build, and is also useful)

The version check retrieves the latest build date from the URL http://iitc.jonatkins.com/devsite/versioncheck.php?build=jonatkins-test&mobile=1 (or ...mobile=0 for desktop) - and this PHP script dynamically reads the version details from the .apk file on disk.

Assuming none of the above helps track down the issue, the full contents of the version check dialog could be useful - a screenshot will do.

— Reply to this email directly or view it on GitHub.

cathesaurus commented 10 years ago

Sorry, replied by email, thought Github would be smart enough to ignore the original text, my bad.

cathesaurus commented 10 years ago

Interesting. I click on the URL, and I see the correct version. But the app check is steadfastly stuck on 0.9.2516.foo

jonatkins commented 10 years ago

I have a thought - there's aggressive caching in IITC mobile. By default used for mobile data only, but options to always/never do it are also available. I bet this is getting in the way, using the old version data from the cache.

Will have to think about the best way to avoid that...

jonatkins commented 10 years ago

borrowing an idea used by the tampermonkey extension for chrome, appending a ts=TIMESTAMP value to the URL should sort it - as the URL is never the same twice.

cathesaurus commented 10 years ago

I'll update to this when the build appears on the site, and let you know whether it correctly notices the next build, whenever that appears. Thanks!

cathesaurus commented 10 years ago

It's correctly informing me that I'm current, so I've every expectation that it'll detect the next update, too. But I'll confirm that in due course.

cathesaurus commented 10 years ago

Confirmed. Detected the new version like a charm, upgraded like a champ. Nice! This issue definitely sorted.