iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

Mobile Test - New Share Function Bug #761

Closed enigmaquip closed 10 years ago

enigmaquip commented 10 years ago

When clicking on a portal and then clicking share you get the new share options. If you try using the in app back button at the top of the share it causes a force close. This happens in both my Nexus 5 and Nexus 7 with the latest build

fkloft commented 10 years ago

Hmm, I can't reproduce that. Which version are you using?

enigmaquip commented 10 years ago

0.10.3.3031.6056cd4

jonatkins commented 10 years ago

Confirmed. The 'back' button is fine, but tapping the top bar to go back crashes - both on Galaxy Nexus (Android 4.3) and Nexus 7 (Android 4.4)

Trying to get logcat output, but neither device wants to connect at the moment...

fkloft commented 10 years ago

It doesn't crash with my own builds, but with the offical ones. I think it might be something with the package name override.

02-04 21:45:54.828: E/AndroidRuntime(26133): FATAL EXCEPTION: main
02-04 21:45:54.828: E/AndroidRuntime(26133): Process: com.cradle.iitc_mobile.test, PID: 26133
02-04 21:45:54.828: E/AndroidRuntime(26133): java.lang.IllegalArgumentException: Activity ShareActivity does not have a parent activity name specified. (Did you forget to add the android.support.PARENT_ACTIVITY <meta-data>  element in your manifest?)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.support.v4.app.NavUtils.navigateUpFromSameTask(NavUtils.java:177)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at com.cradle.iitc_mobile.share.ShareActivity.onOptionsItemSelected(ShareActivity.java:178)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.app.Activity.onMenuItemSelected(Activity.java:2600)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.support.v4.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:366)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at com.android.internal.widget.ActionBarView$3.onClick(ActionBarView.java:167)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.view.View.performClick(View.java:4438)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.view.View$PerformClick.run(View.java:18422)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.os.Handler.handleCallback(Handler.java:733)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.os.Handler.dispatchMessage(Handler.java:95)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.os.Looper.loop(Looper.java:136)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at android.app.ActivityThread.main(ActivityThread.java:5017)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at java.lang.reflect.Method.invokeNative(Native Method)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at java.lang.reflect.Method.invoke(Method.java:515)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
02-04 21:45:54.828: E/AndroidRuntime(26133):    at dalvik.system.NativeStart.main(Native Method)

CC: @leCradle

fkloft commented 10 years ago

Seems to be the same as this. Working on it.

fkloft commented 10 years ago

Should be fixed now. Wait until the builds on the website are updated, then try again.