iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

IITC goes "nowhere" when clicking a portal link from Facebook on computers #797

Closed iAmOren closed 9 years ago

iAmOren commented 10 years ago

Facebook changes commas in links to %2C...

"Fix" v's value in IITC's window.getURLParam function: var v = document.URL.replace(/%2C/g,",");

jonatkins commented 10 years ago

Actually, I noticed recently the server parses the passed URL parameters and makes them available as variables to the javascript:

var MAP_PARAMS = {"lat": xxxx, "lng": xxxx, "zoom": 17, "plng": xxxx, "plat": xxxx};

So we're probably better off using these - as the stock site does.

iAmOren commented 10 years ago

Well, it doesn't work when you post a link on facebook unless you use the fix above. Notice, it breaks on a laptop/desktop using chrome with tampermonkey - for me and others. post this, for example, in facebook, use equipment and software i used, and re-create the problem: http://www.ingress.com/intel?ll=32.07148,34.832618&z=16&pll=32.07148,34.832618

iAmOren commented 10 years ago

Recreate problem by posting: http://www.ingress.com/intel?ll=32.07148,34.832618&z=16&pll=32.07148,34.832618 on facebook on pc with chrome and tampermonkey...

iAmOren commented 10 years ago

how do i "un-close" and what does close mean?!? (newbie to Git)

iAmOren commented 10 years ago

ok... about close and open...

iAmOren commented 10 years ago

Sorry for nagging. Your solution of using variables complicates things, imo. just un-escape(hope it's the correct term) url as suggested... one line change...

jonatkins commented 9 years ago

fixed in 02f41d41ebe995965f38a93829a89e55c3f091b0