iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

IITC Mobile - doesn't load map #85

Closed jonatkins closed 11 years ago

jonatkins commented 11 years ago

I've been working on getting the IITC Mobile working. It builds, but it doesn't work.

This is my first Android app, so I don't know if it's something I'm doing wrong, or if it's just not in a working state at the moment.

@breunigs, @leCradle?

jonatkins commented 11 years ago

I did discover the following in the logcat output

I/ActivityManager( 389): Displayed com.cradle.iitc_mobile/.IITC_Mobile: +670ms E/Web Console(26756): Uncaught SyntaxError: Unexpected identifier at https://www.ingress.com/jsc/gen_dashboard.js:18 E/Web Console(26756): Uncaught ReferenceError: initialize is not defined at https://www.ingress.com/intel:42

jonatkins commented 11 years ago

Also, will it be possible to get the existing keystore to sign this, or will I need to start with a new one?

breunigs commented 11 years ago

unless leCradle shares his with you, you’ll need a new key. Which is super annoying. I believe he will soon start to contribute again, so at least that shouldn’t be an issue.

gen_dashboard.js should actually be replaced with IITC. in /mobile/assets there’s a symlink called iitc.js which should link to the IITC version you want to include in the APK. Is this broken, by chance?

breunigs commented 11 years ago

hm, no, that’s not the case. I’m not exactly sure what could cause that error, since the line referenced is syntactically fine. Debugging is kinda hard because the WebView is not same webkit version as the default browser, for example. my only idea would be to remove large parts of the script and work your way towards a version without syntax error and find the culprit. I tried yuicompressor which usually fails if there’s a syntax error, but no such luck.

leCradle commented 11 years ago

1) if the map just doesn't load I am pretty sure, that the symlink is the problem. How do you build the apk? Are you using the build_mobile script? ....if you use it, it should just work. 2) sorry, but I have to ask this...what is your Android version? It should be 4.0+... 3) Regarding the key...in fact, I used a debug keystore for all my builds...I didn't see any reason to build and sign with a private key unless the app is not pushed to the android market. Of course, I can share the debug.keystore with you...just give me your email...

jonatkins commented 11 years ago

OK, I've just had a chance to rebuild things, this time without "uglifyjs" - and it works. The uglifyjs used here is the stock one in Ubuntu 12.04. Is there a good reason to run IITC through this?

leCradle commented 11 years ago

@jonatkins not anymore I think. We did that to minimize the package size. If we share the apk from an endless traffic server (like iitcm.code-noobs.org), we don't need this anymore... @breunigs ack?

jonatkins commented 11 years ago

OK, I'll do builds without uglifyjs from now on.

I saw your comment on keystores. I have created one for this now, so I'll stick with that now, rather than the debug one (the 12 month expiry of debug keys will hit us at some point)

Any objections to releasing a build of 0.2.3, or are there known issues meaning I should hold off a bit? A quick test on a Galaxy Nexus and Nexus 7 seem to work fine. Here's the link: http://iitc.jonatkins.com/mobile/IITC-Mobile-0.2.3.apk

vita10gy commented 11 years ago

Passes a quicky test on a nexus 4.

leCradle commented 11 years ago

Due to my latest bug fix, v0.2.3 is much more stable....so from my point of view a release is a good idea.

leCradle commented 11 years ago

But note, that everyone uses the apk signed with my debug key...so...you should use the latest build on http://iitcm.code-noobs.org or hint that a deinstall of the old apk is neccessary.

vita10gy commented 11 years ago

Yes, an uninstall was needed. I meant to note that.

I love that it's been added to handle the intents. Makes notifications from niantic way better.

jonatkins commented 11 years ago

Thanks all for your input here. New build is now public.

Closing now as the original issue is fixed.